9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: Nicola Girardi <ng@0x80.stream>
To: 9fans <9fans@9fans.net>
Cc: adr <adr@sdf.org>
Subject: Re: [9fans] Acme: support spaces in file|dir names
Date: Fri, 24 Feb 2023 21:21:43 +0100	[thread overview]
Message-ID: <07dbfdab2895fb49fed8d06102ca640a@0x80.stream> (raw)
In-Reply-To: <fa9d2d4e-0ab-a84a-dd27-82b9ba77a38b@sdf.org>

On 2023-02-20 19:05, adr wrote:
[snip]
> One thing I can't understand is why the text window
> is always redrawn completely when the tag line is edited. I'll take a 
> look
> in the future.

AFAIR from when I looked into it, this behavior was introduced in

commit ba7c22f781dafd30d0b97179c941476639022285
Author: mveety <mveety@gmail.com>
Date:   Wed Aug 28 23:01:23 2013 -0400

     Added the p9p acme patch the allows multiline tags (thanks rsc and 
lf94).

I think the redraw happens because when you add a character to the tag 
you may need to wrap to a new line.
As a stopgap for myself, I've just removed the call to winresize from 
winsettag1.
In principle one should be able to figure out the width of the text in 
the tag and how many lines are needed, and redraw only if that number 
changes after a character is typed, but I wasn't able to figure out 
where to do this in the code.


------------------------------------------
9fans: 9fans
Permalink: https://9fans.topicbox.com/groups/9fans/Tc1d9d9ca3a94e285-Ma59d9fb2950eba76653a7a5c
Delivery options: https://9fans.topicbox.com/groups/9fans/subscription

      parent reply	other threads:[~2023-02-24 20:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-20 16:06 adr
2023-02-20 17:23 ` hiro
2023-02-20 18:05   ` adr
2023-02-20 19:27     ` hiro
2023-02-24 20:21     ` Nicola Girardi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07dbfdab2895fb49fed8d06102ca640a@0x80.stream \
    --to=ng@0x80.stream \
    --cc=9fans@9fans.net \
    --cc=adr@sdf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).