From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <09f98b3b362b408d3d18f16d26c3b671@isd.dp.ua>
To: 9fans@9fans.net
From: yaroslav <yarikos@gmail.com>
Date: Wed, 27 Nov 2013 15:38:18 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Subject: Re: [9fans] u9fs(4) misuses Fcall.afid in its p9any authentication
	module
Topicbox-Message-UUID: 8c3aa4d6-ead8-11e9-9d60-3106f5b1d025

> > /sys/src/cmd/unix/u9fs/authp9any.c
> > authp9any.c.orig:369,375 - /n/sources/patch/u9fs-afid/authp9any.c:369,378
> > fprint(2, "p9anyattach: afid %d state %d\n", rx->afid, sp->state);
> > if (sp->state == Established && strcmp(rx->uname, sp->uname) == 0
> > && strcmp(rx->aname, sp->aname) == 0)
> > + {
> > + rx->uname = sp->t.suid; /* will be valid until afid is clunked */
> > return nil;
> > + }
> > return "authentication failed";
> > }
>
> without commont on correctness, braces go on the
> line on which the if condition ends.
>
> - erik
>

The patch has been updated.

BTW, this change was after http://9fans.net/archive/2011/10/157 which
I hadn't then submitted; this time it slipped through.

It worth's to stay though, IMO.