From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <0d3afe4bf8b675ccc673041bc78bb94c@csplan9.rit.edu> To: 9fans@9fans.net Date: Tue, 15 Apr 2008 18:34:10 -0400 From: john@csplan9.rit.edu In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Subject: Re: [9fans] sshserve.c Topicbox-Message-UUID: 8e964f50-ead3-11e9-9d60-3106f5b1d025 > Yup. usage() is calling itself with no termination condition - and > what's more, it is tail recursing. It should be > > void > usage(void) > { > fprint(2, "usage: sshserve [-A authlist] [-c cipherlist] client-ip- > address\n"); > exits("usage"); > } > > to keep with the Plan 9 program. Enjoy! > > When this QEMU-on-Leopard-freezes-randomly bug gets fixed, I can fix > it and any other dangers. > > On Apr 15, 2008, at 6:05 PM, Kenji Arisawa wrote: > >> Hello, >> >> In sshserve.c: >> >> void >> usage(void) >> { >> fprint(2, "usage: sshserve [-A authlist] [-c cipherlist] client-ip- >> address\n"); >> usage(); >> } >> >> This code can make endless loop. Right? >> >> Kenji Arisawa >> >> Submit a patch! And don't top-post, damn it. We aren't all MicroSavages here. John