9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: erik quanstrom <quanstro@quanstro.net>
To: 9fans@9fans.net
Subject: Re: [9fans] tcp!
Date: Sun, 19 Aug 2012 10:48:23 -0400	[thread overview]
Message-ID: <0d489496d360db95888a3df23d999477@brasstown.quanstro.net> (raw)
In-Reply-To: <1d73e77a5b74942eb88cb5119949c536@hamnavoe.com>

> This looks like a good idea for tcp.  But there are other
> users of qread, with stricter assumptions.  Aren't you in danger
> of breaking the contract of pipe(3) which uses qwrite/qread:
>
>           Writes are atomic up to a certain size, typically 32768
>           bytes, that is, each write will be delivered in a single
>           read by the recipient, provided the receiving buffer is
>           large enough.

this change only applies to Qcoalesce queues.

the only users of Qcoalesce are the kprintoq and tcp.  both
should be okay with this change.

; g qopen port/devpipe.c
port/devpipe.c:68: 	p->q[0] = qopen(conf.pipeqsize, 0, 0, 0);
port/devpipe.c:73: 	p->q[1] = qopen(conf.pipeqsize, 0, 0, 0);

- erik



  parent reply	other threads:[~2012-08-19 14:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-18 20:11 erik quanstrom
2012-08-18 20:26 ` erik quanstrom
2012-08-19 13:37   ` Richard Miller
2012-08-19 13:55     ` cinap_lenrek
2012-08-19 14:05       ` Richard Miller
2012-08-19 15:07         ` erik quanstrom
2012-08-19 14:48     ` erik quanstrom [this message]
2012-08-19 13:17 ` Richard Miller
2012-08-19 15:43   ` erik quanstrom
2012-08-21 18:32 Richard Miller
2012-08-22 17:18 ` Gorka Guardiola
2012-08-22 18:29   ` Steven Stallion
     [not found]   ` <CAGGHmKFokgrbH1P_j+31teoO9ubEvLu2Ti7_QP1+WPLXQ291Mg@mail.gmail.c>
2012-08-22 18:46     ` erik quanstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d489496d360db95888a3df23d999477@brasstown.quanstro.net \
    --to=quanstro@quanstro.net \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).