From mboxrd@z Thu Jan 1 00:00:00 1970 From: erik quanstrom Date: Sun, 19 Aug 2012 10:48:23 -0400 To: 9fans@9fans.net Message-ID: <0d489496d360db95888a3df23d999477@brasstown.quanstro.net> In-Reply-To: <1d73e77a5b74942eb88cb5119949c536@hamnavoe.com> References: <1d73e77a5b74942eb88cb5119949c536@hamnavoe.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Subject: Re: [9fans] tcp! Topicbox-Message-UUID: ac53f796-ead7-11e9-9d60-3106f5b1d025 > This looks like a good idea for tcp. But there are other > users of qread, with stricter assumptions. Aren't you in danger > of breaking the contract of pipe(3) which uses qwrite/qread: > > Writes are atomic up to a certain size, typically 32768 > bytes, that is, each write will be delivered in a single > read by the recipient, provided the receiving buffer is > large enough. this change only applies to Qcoalesce queues. the only users of Qcoalesce are the kprintoq and tcp. both should be okay with this change. ; g qopen port/devpipe.c port/devpipe.c:68: p->q[0] = qopen(conf.pipeqsize, 0, 0, 0); port/devpipe.c:73: p->q[1] = qopen(conf.pipeqsize, 0, 0, 0); - erik