From: erik quanstrom <quanstro@quanstro.net>
To: ebo@sandien.com, 9fans@9fans.net
Subject: Re: [9fans] compiler warnings for libavl/avl.c
Date: Tue, 2 Mar 2010 12:52:09 -0500 [thread overview]
Message-ID: <0d7eca13df84b4712c896f255f4f9285@brasstown.quanstro.net> (raw)
In-Reply-To: <twig.1267551627.47659@swcp.com>
> > > The following two subroutines are defined and not used anywhere. Should they
> > > redefined as void or possibly removed?
> >
> > it's perfectly reasonable to leave code in for testing purposes
> > that never gets called.
>
> Agreed. Should the declarations be changed then to void instead of static
> void so that it does not give warnings? I've worked on some projects where
> the leads where very pedantic about cleaning up all warnings and was wondering
> what the consensus amongst the plan 9 crowd.
how about changing 9c so you don't get this warning?
- erik
next prev parent reply other threads:[~2010-03-02 17:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 9:43 [9fans] Has Anyone compiled 9vx on snow leopard ? prem
2010-02-26 15:16 ` Oleg Finkelshteyn
2010-03-02 17:02 ` [9fans] compiler warnings for libavl/avl.c EBo
2010-03-02 17:12 ` erik quanstrom
2010-03-02 17:40 ` EBo
2010-03-02 17:50 ` Edward E Elzey
2010-03-02 17:52 ` erik quanstrom [this message]
2010-03-02 18:41 ` EBo
2010-03-04 18:10 ` Russ Cox
2010-03-01 9:49 ` [9fans] Has Anyone compiled 9vx on snow leopard ? prem
2010-03-01 9:49 ` prem
2010-03-01 10:30 ` John Stalker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d7eca13df84b4712c896f255f4f9285@brasstown.quanstro.net \
--to=quanstro@quanstro.net \
--cc=9fans@9fans.net \
--cc=ebo@sandien.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).