9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: Ethan Gardener <eekee57@fastmail.fm>
To: 9fans@9fans.net
Subject: Re: [9fans] Acme resize bug
Date: Mon, 31 Dec 2018 10:17:49 +0000	[thread overview]
Message-ID: <1546251469.2699466.1622066408.1D64CC37@webmail.messagingengine.com> (raw)
In-Reply-To: <CA+gzr0KC+Fg6AquDzWF0rQfwHNcxpPmQq7xJ6C7jY4z22R4ayQ@mail.gmail.com>

On Sun, Dec 30, 2018, at 10:22 PM, Jacob Moody wrote:
> Hello 9fans,
>
> I've noticed that sometimes when resizing acme columns there is a
> strip left at the bottom that doesn't get redrawn.
> It's a bit hard to notice with the default colours, but changing it up
> makes it more obvious.
> I was able to fix it with this the following patch but am not sure if
> this is the best way to go about fixing it.
>
> diff -u /dist/clean/plan9front/sys/src/cmd/acme/cols.c /sys/src/cmd/acme/cols.c
> --- /dist/clean/plan9front/sys/src/cmd/acme/cols.c Thu Nov  1 15:02:44 2018
> +++ /sys/src/cmd/acme/cols.c Thu Nov  1 15:38:53 2018
> @@ -204,6 +204,7 @@
>   draw(screen, r2, display->black, nil, ZP);
>   r1.min.y = r2.max.y;
>   r1.min.y = winresize(w, r1, FALSE);
> + draw(screen, r1, textcols[BACK], nil, ZP);
>   }
>   c->r = r;
>  }

That will work, but that strip which doesn't get redrawn is also where Acme won't see the mouse as being in any window or tag.  Since it's sometimes useful to see it, you might want to draw it in display->back or display->white, I guess.  If one of those is already your background color i guess you'll need a new global pointer for a new color, or maybe use an existing color which happens to be subtly different.

I'm not posting my code, my brain switches off half-way through finding out how to do it, and then I forget what I've done until I want to post it here and look it up...



      reply	other threads:[~2018-12-31 10:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-30 22:22 Jacob Moody
2018-12-31 10:17 ` Ethan Gardener [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1546251469.2699466.1622066408.1D64CC37@webmail.messagingengine.com \
    --to=eekee57@fastmail.fm \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).