Re: [9fans] broken vac

[Fco.J.Ballesteros <nemo@plan9.escet.urjc.es>]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

Change vtLockFree with this:

void
vtLockFree(VtLock *p)
{
	if(p == nil)
		return;
	assert(p->writer == nil);
	assert(p->readers == 0);
	assert(p->qfirst == nil);
	vtMemFree(p);
}

[-- Attachment #2: Type: message/rfc822, Size: 5942 bytes --]

From: Axel Belinfante <Axel.Belinfante@cs.utwente.nl>
To: 9fans@cse.psu.edu
Subject: [9fans] broken vac
Date: Fri, 31 Jan 2003 16:08:46 +0100
Message-ID: <200301311508.h0VF8kD03966@zamenhof.cs.utwente.nl>

I'm trying to vac the dump of my current fs,
using a modified version of nemo's mkvac script.

At a particular point, this resulted in a broken vac,
see acid dump below. I retried (with same arguments),
with the same result.
Then I tried to vac other (more recent) /n/dump
directories, and that worked without problem.
Any ideas, anyone? If more information would help
to track down the problem, just let me know.

Axel.


The vac command was:

vac -s -f dump/ofs/2002_0101.vac -d dump/ofs/2003_0101.vac -q /n/dump/2002/0101

cpu% ls -l vac
--rwxrwxr-x M 1246 sys sys 173711 Dec 15 02:11 /386/bin/vac


cpu% acid 8720
/proc/8720/text:386 plan 9 executable

/sys/lib/acid/port
/sys/lib/acid/386
acid: lstk()
At pc:0x00010b2e:abort /sys/src/libc/9sys/abort.c:6
abort() /sys/src/libc/9sys/abort.c:6
	called from _assert+0x3a /sys/src/libc/port/_assert.c:12
_assert(s=0x0001b388) /sys/src/libc/port/_assert.c:7
	called from vtLockFree+0x54 /sys/src/libventi/plan9.c:245
vtLockFree(p=0x05090008) /sys/src/libventi/plan9.c:240
	called from vfFree+0x27 /sys/src/cmd/vac/file.c:265
vfFree(vf=0x0508ff48) /sys/src/cmd/vac/file.c:261
	called from vfDecRef+0x8f /sys/src/cmd/vac/file.c:983
vfDecRef(vf=0x0508ff48) /sys/src/cmd/vac/file.c:954
	called from vacDir+0x1cc /sys/src/cmd/vac/vac.c:608
	p=0x0506d968
	qq=0x0506d9f8
vacDir(dsink=0x0504ae60,fd=0x00000008,lname=0x0506d8e8,sname=0x0506d928,vf=0x05
06d968) /sys/src/cmd/vac/vac.c:581
	called from vacFile+0x17f /sys/src/cmd/vac/vac.c:437
	ds=0x0506dcc8
	dirs=0x0509ff08
	nd=0x00000043
	i=0x00000000
	name=0x050a0ebc
	ln=0x0508fea8
	sn=0x0508ff08
	vvf=0x0508ff48
vacFile(lname=0x0506d8e8,dsink=0x0504ae60,sname=0x0506d928,vf=0x0506d968) 
/sys/src/cmd/vac/vac.c:399
	called from vacDir+0x1bb /sys/src/cmd/vac/vac.c:605
	fd=0x00000008
	entry=0x00000000
	dir=0x0506dbe8
	vd=0x00000000
vacDir(dsink=0x050295d0,fd=0x00000007,lname=0x0504aac0,sname=0x0504ab00,vf=0x05
04ab40) /sys/src/cmd/vac/vac.c:581
	called from vacFile+0x17f /sys/src/cmd/vac/vac.c:437
	ds=0x0504ae60
	dirs=0x0507d948
	nd=0x00000009
	i=0x00000000
	name=0x0507db64
	ln=0x0506d8e8
	sn=0x0506d928
	vvf=0x0506d968
vacFile(lname=0x0504aac0,dsink=0x050295d0,sname=0x0504ab00,vf=0x0504ab40) 
/sys/src/cmd/vac/vac.c:399
	called from vacDir+0x1bb /sys/src/cmd/vac/vac.c:605
	fd=0x00000007
	entry=0x00000002
	dir=0x0504ad80
	vd=0x00000000
vacDir(dsink=0x00040438,fd=0x00000006,lname=0x7fffefea,sname=0x7fffeff7,vf=0x05
0292b0) /sys/src/cmd/vac/vac.c:581
	called from vacFile+0x17f /sys/src/cmd/vac/vac.c:437
	ds=0x050295d0
	dirs=0x0505ab68
	nd=0x0000001a
	i=0x00000001
	name=0x0505b1c1
	ln=0x0504aac0
	sn=0x0504ab00
	vvf=0x0504ab40
vacFile(lname=0x7fffefea,dsink=0x00040438,sname=0x7fffeff7,vf=0x050292b0) 
/sys/src/cmd/vac/vac.c:399
	called from vac+0x235 /sys/src/cmd/vac/vac.c:308
	fd=0x00000006
	entry=0x00000000
	dir=0x050294f0
	vd=0x00000000
vac(z=0x0001f328,argv=0x7fffefa0) /sys/src/cmd/vac/vac.c:253
	called from main+0x152 /sys/src/cmd/vac/vac.c:187
	cwd=0x7273752f
	dsink=0x00040438
	fs=0x00062488
	fd=0x00000004
	dir=0x050291d0
	cd=0x00000001
	cp2=0x7fffeff7
	vff=0x050292b0
	ms=0x000015c2
	vd=0x00000000
	ds=0x0000ccb0
	root=0x00012177
	buf=0x00000000
	score=0x00011f45
	i=0x00000000
main(argv=0x7fffefa0,argc=0x00000001) /sys/src/cmd/vac/vac.c:101
	called from _main+0x31 /sys/src/libc/386/main9.s:16
	host=0x00000000
	statsFlag=0x00000001
	_argc=0x00000071
	_args=0x7fffefe9
	p=0x00000000
	z=0x0001f328
acid: