9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: Vadim Antonov avg@postman.ncube.com
Subject: BUG FIX for getwd()
Date: Thu, 17 Aug 1995 00:35:07 -0400	[thread overview]
Message-ID: <19950817043507.2LhkKy_fQumyi0zrZFowRzy50ku5atJAj8mxIhZCZsk@z> (raw)


----FORWARDED MESSAGE----
From: markw@kira (Mark Wiley)
Subject: This is too much fun to keep to myself ...

If you call getwd with a buffer which it too small to contain
the current working directory, it returns 0 and places the message
'buffer too small' in the buffer EVEN if the buffer is too small
to contain that message.

Sigh.

Markw
-------------------------

The fix is appended, although the right way
to do things would be to change the way the
error message is returned (it should be in errstr...)

--vadim

File /sys/src/libc/9sys/getwd.c:

naiad% diff getwd.c.old getwd.c
14c14
< getwd(char *s , int size)
---
> getwd(char *s , int size0)
18a19
>       int size;
19a21
>       size = size0;
22c24
<               strcpy(s, "stat of / failed");
---
>               strncpy(s, "stat of / failed", size0);
29c31
<                       strcpy(s, "stat of . failed");
---
>                       strncpy(s, "stat of . failed", size0);
51c53
<                       strcpy(s, "chdir .. failed");
---
>                       strncpy(s, "chdir .. failed", size0);
65c67
<                       strcpy(s, "buffer too small");
---
>                       strncpy(s, "buffer too small", size0);
77c79
<               strcpy(s, "failed to return to .");
---
>               strncpy(s, "failed to return to .", size0);






                 reply	other threads:[~1995-08-17  4:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19950817043507.2LhkKy_fQumyi0zrZFowRzy50ku5atJAj8mxIhZCZsk@z \
    --to=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).