9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: Vadim Antonov avg@postman.ncube.com
Subject: More bugs.
Date: Thu, 17 Aug 1995 02:47:52 -0400	[thread overview]
Message-ID: <19950817064752.rXTG3LCzjtnMFIRreHZVz8RYGIov-LoMkfVPQO5arvc@z> (raw)

/sys/src/cmd/auth/lib/readln didn't turn raw mode off
before sending newline (which caused some funny behaviour
if the server translates the newline differently in
raw and cooked modes).  Also, in some cases closed
stream could be interpreted as DEL by readln.

The quick fix is appended.  As always, the real fix
would be to make echo-on and echo-off _separate_
from raw-on and raw-off.  I remember seeing the same
kind of problem in Unix version 6.  I guess aliens from
outer space kept somebody in suspended animation all
those years :)


--vadim

naiad% pwd
/sys/src/cmd/auth/lib
naiad% diff readln.c.old readln.c
49,50d48
<               if(*p == 0x7f)
<                       exits(0);
53c51,52
<                       if(raw)
---
>                       if(raw) {
>                               write(ctl, "rawoff", 6);
54a54
>                       }
58a59,60
>               if(*p == 0x7f)
>                       exits(0);
naiad%






             reply	other threads:[~1995-08-17  6:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1995-08-17  6:47 Vadim [this message]
1995-08-17 10:01 Vadim
1995-08-17 11:22 Vadim
1995-08-17 23:52 Boyd
1995-08-18  1:15 Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19950817064752.rXTG3LCzjtnMFIRreHZVz8RYGIov-LoMkfVPQO5arvc@z \
    --to=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).