acme buglet

acme buglet

[Sandy]

Scott Schwartz  <schwartz@galapagos.CSe.psu.EDU> wrote:

>Rob sent me a different patch for that bug.  Here it is.
>
>fix in util.l:
>
>byte*
>runetobyte(Rune *r, int n)
>{
>	byte *s;
>
>>	if(n == 0)
>>		return nil;
>	s = malloc(n*UTFmax+1);
>	snprint(s, n*UTFmax+1, "%.*S", n, r);
>	return s;
>}
What does this do if the malloc() fails?
 --
 Sandy Harris
 sharris@fox.nstn.ca

acme buglet

[Rob]

>>	s = malloc(n*UTFmax+1);
>>	snprint(s, n*UTFmax+1, "%.*S", n, r);

> What does this do if the malloc() fails?

malloc() never fails in-line in alef.  if memory
is not available, malloc() issues a check, which
in acme will cause an attempt at a save and
exit.  of course, if malloc fails, so will the save,
but at least it tries.

acme buglet

[philw]

malloc does not return nil in ALEF.

acme buglet

[Scott]

Rob sent me a different patch for that bug.  Here it is.

fix in util.l:

byte*
runetobyte(Rune *r, int n)
{
	byte *s;

>	if(n == 0)
>		return nil;
	s = malloc(n*UTFmax+1);
	snprint(s, n*UTFmax+1, "%.*S", n, r);
	return s;
}

acme buglet

[forsyth]

a student found this.  you have to coax acme to trigger it:
get an empty New frame, add Put to the tag, and click on it.

vortex% diff $home/cd/cmd/acme/exec.l .
317a318,319
> 			if(t->file->name == nil)
> 				return nil;