From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 15 Dec 1997 09:43:11 -0800 From: Eric Dorman eld@jewel.ucsd.edu Subject: [9fans] Re: etherelnk3.c Topicbox-Message-UUID: 6dc0f9ca-eac8-11e9-9e20-41e7f4b1d025 Message-ID: <19971215174311.p0Hq7y3GxIDWo02tu7GzSB-T-ITUtM4smUCkxLs53CM@z> > From: "G. David Butler" > To: 9fans@cse.psu.edu > Subject: [9fans] Re: etherelnk3.c > > Hello All! > > I've just started the process of back porting the brazil > etherelnk3 driver to Plan9. I would like some feedback > from this list (9fans) about some of the porting issues. [xxx] > After a quick perusal of the code, we have a big decision > to make. This brazil driver does not use RingBuf, it uses > Blocks. It also moves the Ctlr structure out of ether.h > and into the driver .c file. The former change allows > more data to be buffered and the latter allows driver > specific data to be localized. These are both "good" things. > Devether.c is not compatible with either of these changes, > so we have to either update the entire ethernet subsystem to > use Blocks, or make this driver use RingBufs and dirty the > ether.h Card and Ctlr structures with the overhead of this > driver. Another thing to consider is how these changes would affect the integration of ether drivers between the fs and terminal code. Integrating these two trees first allieviates a whole mess of existing problems and ensures that this type of effort won't have to be done again (perhaps differently, even) for fs. > David Butler > gdb@dbSystems.com Regards, Eric L. Dorman University of California at San Diego edorman@ucsd.edu