From mboxrd@z Thu Jan  1 00:00:00 1970
From: erik quanstrom <quanstro@labs.coraid.com>
Date: Fri, 30 Mar 2012 11:53:28 -0400
To: yarikos@gmail.com, 9fans@9fans.net
Message-ID: <1bf2ac4c1f082d686c4a21cd8428614b@coraid.com>
In-Reply-To: <CAG3N4d_mEkM2CeEQ-WhqKmK2_WbJz6X_N2JQkaR6QMRtThkw_w@mail.gmail.c>
References: <CAG3N4d_mEkM2CeEQ-WhqKmK2_WbJz6X_N2JQkaR6QMRtThkw_w@mail.gmail.c>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [9fans] nfactotum: mschap fix
Topicbox-Message-UUID: 729748b4-ead7-11e9-9d60-3106f5b1d025

> /n/sources/contrib/quanstro/root/sys/src/cmd/auth/factotum/chap.c:153,1=
66
> - /sys/src/cmd/auth/factotum/chap.c:154,163
> =C2=A0 =C2=A0 =C2=A0 =C2=A0c->state =3D "read challenge";
> =C2=A0 =C2=A0 =C2=A0 =C2=A0if((nchal =3D convreadm(c, (char**)(void*)&c=
hal)) < 0)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0goto out;
> - =C2=A0 =C2=A0 =C2=A0 if(astype =3D=3D AuthMSchap && nchal !=3D MSchal=
len)
> - =C2=A0 =C2=A0 =C2=A0 c->state =3D "write user";
> =C2=A0 =C2=A0 =C2=A0 =C2=A0if((user =3D strfindattr(k->attr, "user")) =3D=
=3D nil){
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0werrstr("key has=
 no user (cannot happen?)");
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0goto out;
> =C2=A0 =C2=A0 =C2=A0 =C2=A0}
> - =C2=A0 =C2=A0 =C2=A0 if(convprint(c, "%s", user) < 0)
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 goto out;

surely you need to use the "user" attribute.  if you don't please send
a copy of chap that doesn't give compiler warnings.

- erik