9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: Skip Tavakkolian <9nut@9netics.com>
To: 9fans@9fans.net
Subject: Re: [9fans] compiling xen3 with more recent pc kernel
Date: Sun, 21 Jun 2015 15:02:15 -0700	[thread overview]
Message-ID: <1da684cfe23ffc1ad92ffebc6837646b@9netics.com> (raw)
In-Reply-To: <20150621233253.1d74c860@zinc.9fans.fr>

thanks.

i saw the note and was wondering if for xen3 it could be
stubbed out.

>> i had to make the following changes to the kernel for xen3 to match up
>> to recent labs pc kernel and to compile successfully.  can anyone
>> verify the changes are correct?  (i could to a smoke test on EC2, but
>> don't feel adventurous at the moment)
>
> The evenaddr function in trap.c should be replaced by validalign:
>
> void
> validalign(uintptr addr, unsigned align)
> {
> 	/*
> 	 * Plan 9 is a 32-bit O/S, and the hardware it runs on
> 	 * does not usually have instructions which move 64-bit
> 	 * quantities directly, synthesizing the operations
> 	 * with 32-bit move instructions. Therefore, the compiler
> 	 * (and hardware) usually only enforce 32-bit alignment,
> 	 * if at all.
> 	 *
> 	 * Take this out if the architecture warrants it.
> 	 */
> 	if(align == sizeof(vlong))
> 		align = sizeof(long);
>
> 	/*
> 	 * Check align is a power of 2, then addr alignment.
> 	 */
> 	if((align != 0 && !(align & (align-1))) && !(addr & (align-1)))
> 		return;
> 	postnote(up, 1, "sys: odd address", NDebug);
> 	error(Ebadarg);
> 	/*NOTREACHED*/
> }
>
> This is a change done by Jim McKie on 2014-05-15.
>
> --
> David du Colombier




      reply	other threads:[~2015-06-21 22:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-21 21:22 Skip Tavakkolian
2015-06-21 21:32 ` David du Colombier
2015-06-21 22:02   ` Skip Tavakkolian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1da684cfe23ffc1ad92ffebc6837646b@9netics.com \
    --to=9nut@9netics.com \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).