Re: [9fans] The VT saga

[Micah Stetson <micah@cnm-vra.com>]

[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]

> Surely Rob should be arbitrator.  I have not had time to look at the
> patch, but I'd like to point out one issue I have not examined and I
> don't think the patch addressed: the highlight termination does not work,
> vt (-2 is what I always use) waits for the end of line to turn highlight
> off.

Hmmn, I hadn't paid any attention to vt -2.  I don't have
the problem without it and not always with it.  Maybe
there's an unimplemented VT220 escape sequence that does
that.  Let me grab the manual...  (Incidentally, if you
want a user's guide, you can download one from vt100.net.
They have the manuals for several of the VT models including
the 100 102 and 220.)  Hmmn...It looks like the VT220 uses
some nonzero arguments to the SGR control sequence (ESC[m)
to set certain kinds of standout to off.  The current
implementation will not support this properly.

Attached is a diff against the version of vt.c that I posted
here a couple of days ago.  This is still problematic as it
only handles the last option to the control sequence, but if
I'm going to fix that, I may as well do it for all of the
escape sequences.  Also, it interprets the vt220 options
even when in vt100 mode which it probably shouldn't do, but
it does fix the problem for me.

There's still a lot to fix here, especially in vt220 mode,
so I'll get back to work.

Micah


[-- Attachment #2: vt.c.diff --]
[-- Type: text/plain, Size: 972 bytes --]

56a57,63
> enum SGR {
> 	SGR_BOLD = 1,
> 	SGR_UNDER = 2,
> 	SGR_BLINK = 4,
> 	SGR_NEG = 8,
> };
> 
439a447,451
> 					 *	Also for VT220:
> 					 *	22	Normal intensity
> 					 *	24	Not underlined
> 					 *	25	Not blinking
> 					 *	27	Positive image
442c454,482
< 						standout = operand;
---
> 						switch (operand) {
> 							case 0:
> 								standout = 0;
> 								break;
> 							case 1:
> 								standout |= SGR_BOLD;
> 								break;
> 							case 4:
> 								standout |= SGR_UNDER;
> 								break;
> 							case 5:
> 								standout |= SGR_BLINK;
> 								break;
> 							case 7:
> 								standout |= SGR_NEG;
> 								break;
> 							case 22:
> 								standout &= ~SGR_BOLD;
> 								break;
> 							case 24:
> 								standout &= ~SGR_UNDER;
> 								break;
> 							case 25:
> 								standout &= ~SGR_BLINK;
> 								break;
> 							case 27:
> 								standout &= ~SGR_NEG;
> 								break;
> 						}