Re: [9fans] I still dont understand...

[David Gordon Hogan <dhog@plan9.bell-labs.com>]

There are some bugs in the upas/fs plaintext POP implementation, which
probably weren't detected because upas/fs insists on APOP if the server
supports it.  Here's a patch for them.  Note that there is another bug -- upas/fs
will die if your POP mbox has 0 messages.  I haven't got around to fixing that.

/n/dump/2001/0716/sys/src/cmd/upas/fs/pop3.c:132,133 c /n/dump/2001/0705/sys/src/cmd/upas/fs/pop3.c:132,133
< 		sprint(buf, "/mnt/auth/pop/%s/%s", pop->host, pop->user);
< 		if((fd = open(buf, OREAD)) < 0)
---
> 		sprint(buf, "/mnt/auth/pop3/%s/%s", pop->host, pop->user);
> 		if((fd = open(buf, ORDWR)) < 0)
/n/dump/2001/0716/sys/src/cmd/upas/fs/pop3.c:469 c /n/dump/2001/0705/sys/src/cmd/upas/fs/pop3.c:469
< 	int nf, ppop;
---
> 	int nf;
/n/dump/2001/0716/sys/src/cmd/upas/fs/pop3.c:472,473 c /n/dump/2001/0705/sys/src/cmd/upas/fs/pop3.c:472
< 	ppop = strncmp(path, "/pop/", 5) == 0;
< 	if(!ppop && strncmp(path, "/apop/", 6) != 0)
---
> 	if(strncmp(path, "/pop/", 5) != 0 && strncmp(path, "/apop/", 6) != 0)
/n/dump/2001/0716/sys/src/cmd/upas/fs/pop3.c:491 c /n/dump/2001/0705/sys/src/cmd/upas/fs/pop3.c:490,491
< 	pop->ppop = ppop;
---
> 	if(strncmp(path, "/pop/", 5) == 0)
> 		pop->ppop = 1;