From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Russ Cox" To: 9fans@cse.psu.edu Subject: Re: [9fans] lucio- MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="upas-jivuiwwotszdftpedsxacpxvcj" Message-Id: <20020109050805.9394F19A70@mail.cse.psu.edu> Date: Wed, 9 Jan 2002 00:08:04 -0500 Topicbox-Message-UUID: 3c46f276-eaca-11e9-9e20-41e7f4b1d025 This is a multi-part message in MIME format. --upas-jivuiwwotszdftpedsxacpxvcj Content-Disposition: inline Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit > No offense meant, but doesn't this show precisely what CVS's strength > is? Had you recorded the fix, we wouldn't be still looking for it :-) It shows that I should keep better records of what I do each day. Even if I had the CVS source under CVS, I probably would have thrown out the repository when I ported the new one. Further, I'm not sure whether the bug was in CVS or in APE. If I remembered what was broken, I could run history to find it. Case in point: I just found it, by poking around for files in /sys/src/ape modified about the same date as when I ported the new CVS (which I remember being near when I found the bug). CVS wouldn't have helped any more than the dump here. The bug is in /sys/src/ape/lib/ap/plan9/getcwd.c. Replace the entire file with: #include "lib.h" #include #include #include #include #include #include #include "sys9.h" #include "dir.h" char* getcwd(char *buf, size_t len) { int fd; fd = _OPEN(".", OREAD); if(fd < 0) { errno = EACCES; return 0; } if(_FD2PATH(fd, buf, len) < 0) { errno = EIO; _CLOSE(fd); return 0; } _CLOSE(fd); return buf; } Exercise to the reader: find the fd leak in the original. Russ --upas-jivuiwwotszdftpedsxacpxvcj Content-Type: message/rfc822 Content-Disposition: inline Received: from plan9.cs.bell-labs.com ([135.104.9.2]) by plan9; Tue Jan 8 23:54:15 EST 2002 Received: from mail.cse.psu.edu ([130.203.4.6]) by plan9; Tue Jan 8 23:54:13 EST 2002 Received: from psuvax1.cse.psu.edu (psuvax1.cse.psu.edu [130.203.16.6]) by mail.cse.psu.edu (CSE Mail Server) with ESMTP id 1A1DF19A74; Tue, 8 Jan 2002 23:54:06 -0500 (EST) Delivered-To: 9fans@cse.psu.edu Received: from cackle.proxima.alt.za (unknown [196.30.44.141]) by mail.cse.psu.edu (CSE Mail Server) with ESMTP id CA2C619A74 for <9fans@cse.psu.edu>; Tue, 8 Jan 2002 23:53:01 -0500 (EST) Received: (from lucio@localhost) by cackle.proxima.alt.za (8.9.3/8.9.1) id GAA14146 for 9fans@cse.psu.edu; Wed, 9 Jan 2002 06:53:00 +0200 (SAST) From: Lucio De Re To: 9fans@cse.psu.edu Subject: Re: [9fans] lucio- Message-ID: <20020109065259.G12098@cackle.proxima.alt.za> Mail-Followup-To: 9fans@cse.psu.edu References: <20020109030647.9FEA619A45@mail.cse.psu.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.4us In-Reply-To: <20020109030647.9FEA619A45@mail.cse.psu.edu>; from Russ Cox on Tue, Jan 08, 2002 at 10:06:45PM -0500 Sender: 9fans-admin@cse.psu.edu Errors-To: 9fans-admin@cse.psu.edu X-BeenThere: 9fans@cse.psu.edu X-Mailman-Version: 2.0.8 Precedence: bulk Reply-To: 9fans@cse.psu.edu X-Reply-To: lucio@proxima.alt.za List-Help: List-Id: Fans of the OS Plan 9 from Bell Labs <9fans.cse.psu.edu> List-Archive: Date: Wed, 9 Jan 2002 06:52:59 +0200 On Tue, Jan 08, 2002 at 10:06:45PM -0500, Russ Cox wrote: > > For the list, I've fixed this bug before. > I remember it being a neat bug, but I don't > remember what it was. Once Lucio and I figure > it out again, one of us will post what the > problem was. Perhaps it was cvs, perhaps APE, > perhaps some weird interaction between the > two. I've been trying to remember all day. > No offense meant, but doesn't this show precisely what CVS's strength is? Had you recorded the fix, we wouldn't be still looking for it :-) But I agree wholeheartedly that CVS is only a partial solution and that the needs it attempts to address vary widely. I'm tempted to create a mailing list specially to discuss a CVS-like development that merges the Plan 9 backup technology into it. Any takers? ++L --upas-jivuiwwotszdftpedsxacpxvcj--