From mboxrd@z Thu Jan 1 00:00:00 1970 Message-Id: <200202062015.VAA03744@boris.cd.chalmers.se> To: 9fans@cse.psu.edu Subject: Re: [9fans] XP (was: code complexity) In-reply-to: Your message of "Tue, 05 Feb 2002 18:49:39 +0100." <3C601B33.DB8558E6@strakt.com> From: Laura Creighton Date: Wed, 6 Feb 2002 21:15:18 +0100 Topicbox-Message-UUID: 4ddcec7a-eaca-11e9-9e20-41e7f4b1d025 One reason that some people do not sit down and make their code simpler is because nobody has ever told them to do that before. At any rate, when I insist on it, I keep getting told that I am the first person who has. The ones with bad attitudes are helped when they notice that other people are also simplifying. I think that a lot of people are taught that 'Only the stupid people in class ever have to write an answer over again. Smart people get it perfectly correct the first time.' So they are badly offended when you tell them to do it over again, because they think that you are telling them that they are stupid fools. (I have heard a variation from students which goes 'if I had wanted to revise things, I would have become an Humanities major'.) I also think that polite people learn to not mention that _other people_ have poorly written code, until they cannot notice that _they_ have written poor code. We had student interns here last summer. Very early on, the first week, I held a code review of some code I had written in one hell of a hurry. And it was many, many hours before they felt that it was in some way, _permitted_ for them to point out flaws in my code. Finally they got the idea. And really liked savaging their elders for carelessness, and ugliness, and complexity, and all sorts of good stuff. But first they had to know that we really wanted to hear this. Before that it was disrespectful. Laura Creighton