Re: [9fans] RTL 8139 driver

Re: [9fans] RTL 8139 driver

[andrey mirtchovski]

stragne problem. i couldn't find why it wouldn't compile (Timer is now a
reserved word, perhaps?) but changing 'Timer' to 'Time' or 'Timer1' on
lines 76, 355 and 588 of ether8139.c would solve it...

On Sun, 28 Apr 2002 plan9@itic.ca wrote:

> I wanted to try rtl8139 under r4
> I added in plan9.ini
[snip]

[9fans] RTL 8139 driver

[plan9]

I wanted to try rtl8139 under r4
I added in plan9.ini
	ether0=type=rtl8139
but binding claims that :
	no free devices
Then I tried with 3 <> models having RTL8139
	same problem...

Finally, I added a line 
	ether8139	pci
in the /sys/src/9/pc/pcdisk file but now compilation claims that :
	8c -FVw ether8139.c
	ether8139.c:76 syntax error, last name Timer

Any idea ?

Re: [9fans] RTL 8139 driver

[plan9]

Thanks Rob,

Now compilation goes on.

The cards still do not work.

All have a RTL8139B chip, which is probably the issue.

Note : 9LOAD detect all of them correctly

Re: [9fans] RTL 8139 driver

[rob pike, esq.]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

Oops.  Yes, 'Timer' is now a defined type so can't be used as an
enumerated constant.  Looks like we didn't try compiling this
driver recently.  I changed 'Timer' to 'Timerbit' and it compiled.

/n/emelieother/plan9//sys/src/9/pc/ether8139.c:76 c /sys/src/9/pc/ether8139.c:76
< 	Timer		= 0x4000,	/* Timer */
---
> 	Timerbit		= 0x4000,	/* Timer */
/n/emelieother/plan9//sys/src/9/pc/ether8139.c:355 c /sys/src/9/pc/ether8139.c:355
< 	csr16w(ctlr, Imr, Serr|Timer|Fovw|PunLc|Rxovw|Ter|Tok|Rer|Rok);
---
> 	csr16w(ctlr, Imr, Serr|Timerbit|Fovw|PunLc|Rxovw|Ter|Tok|Rer|Rok);
/n/emelieother/plan9//sys/src/9/pc/ether8139.c:588 c /sys/src/9/pc/ether8139.c:588
< 			if(isr & Timer)
---
> 			if(isr & Timerbit)

[-- Attachment #2: Type: message/rfc822, Size: 1857 bytes --]

From: <plan9@itic.ca>
To: <9fans@cse.psu.edu>
Subject: [9fans] RTL 8139 driver
Date: Sun, 28 Apr 2002 08:36:18 -0500
Message-ID: <FIEDLHOOAEHBJAPIKGJCOECECBAA.plan9@itic.ca>

I wanted to try rtl8139 under r4
I added in plan9.ini
	ether0=type=rtl8139
but binding claims that :
	no free devices
Then I tried with 3 <> models having RTL8139
	same problem...

Finally, I added a line 
	ether8139	pci
in the /sys/src/9/pc/pcdisk file but now compilation claims that :
	8c -FVw ether8139.c
	ether8139.c:76 syntax error, last name Timer

Any idea ?