From mboxrd@z Thu Jan  1 00:00:00 1970
Message-Id: <200302101453.h1AEr0Z20581@zamenhof.cs.utwente.nl>
To: 9fans@cse.psu.edu
Subject: Re: [9fans] mpg123
In-reply-to: Your message of "Mon, 10 Feb 2003 15:34:04 +0100."
             <838b9e71b3d2c9e015ed50b2bd73c32c@plan9.escet.urjc.es>
References: <838b9e71b3d2c9e015ed50b2bd73c32c@plan9.escet.urjc.es>
From: Axel Belinfante <Axel.Belinfante@cs.utwente.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <20579.1044888780.1@zamenhof.cs.utwente.nl>
Date: Mon, 10 Feb 2003 15:53:00 +0100
Topicbox-Message-UUID: 5606a0d4-eacb-11e9-9e20-41e7f4b1d025

> The mad player uses fixed point and is quite optimized.
> I think the ported version is in our web page.
> It's what I use in the bitsy and works properly there
> (needless to say on a pc).

I used it, took it from your web page, but I found that
there are some mp3's which it doesn't play but which
mpg123 does play.  (something to do with mp3 headers?)

> Because it computes (around line 170 of layer3.c)
> 1 - tan(3 * Pi / 4)     which is 0
> and then a series of values which involve dividing
> by it.

I hacked around this in mpg123  by checking for a
divisor of 0.0 and replacing it by something small
but unequal to zero.  I got away with that but
Nigels solution (which I did not try) looks nicer.

> I would guess that row 9 of the table is not used,
> so that putting
>	 if (i == 9) continue;
> in the loop will fix it.

Axel.