9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: Lucio De Re <lucio@proxima.alt.za>
To: 9fans mailing list <9fans@cse.psu.edu>
Subject: [9fans] Still puzzled by Venti
Date: Mon,  7 Jul 2003 11:01:39 +0200	[thread overview]
Message-ID: <20030707110139.V16824@cackle.proxima.alt.za> (raw)

... which incidentally still refuses to work as advertised :-(

The constant "IndexBase" is used exclusively in
/sys/src/cmd/venti/fmtindex.c after being defined (as 1024 * 1024) in
.../venti/dat.h.

The code that uses it seems flawed to me: it assumes that

	addr = IndexBase;

as assigned before a loop through the contents of the Venti config
file, can be used as the arenas start address, which is not entirely
unjustified if the index is meant to start, as given in a comment in
dat.h:

	IndexBase = 1024*1024,	/* initial address to use in an index */

but is wrong when used in computing the beginning of the next arena
(and the end of the present one) by adding to it the current arena
size:

	amap[n].start = addr;
	addr += ap->arenas[j]->size;
	amap[n].stop = addr;

I'm not sure what the correct adjustment should be here, but the upper
limit should certainly remain within the arena:

	amap[n].stop = addr - IndexBase + ap->arenaBase;

Whether this is not just my imagination running wild, remains to be
decided.  Unfortunately, I don't know how to test this, because I'm
not sure what the importance of the initial unused space is.  I guess
I can but try the exact change suggested above and see what its effect
is going to be.

++L


                 reply	other threads:[~2003-07-07  9:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030707110139.V16824@cackle.proxima.alt.za \
    --to=lucio@proxima.alt.za \
    --cc=9fans@cse.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).