From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Michaelson <ggm@apnic.net>
To: 9fans@cse.psu.edu
Message-Id: <20040212110604.478bfdca@garlic>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [9fans] the return of cat -v (NetBSD sources)
Date: Thu, 12 Feb 2004 11:06:04 +1000
Topicbox-Message-UUID: df1f8452-eacc-11e9-9e20-41e7f4b1d025

from a posting to a NetBSD list...

-George

----
Hi people,

I'm not sure this is the right list, but I have noticed that the code for
/bin/cat includes several gotos which were inserted when the -f flag was
implemented (starting from line 252 on version 1.43).
To me these gotos look like a quick patch (especially with names like "skip" :))
and seem like a good start for a spaghetti code... but I'm no expert.

My question is this: wouldn't it be more clean to implement these using a flag?
This way the danger of code additions which will make "skip" move too far and
become obscure will disappear.

According to http://www.netbsd.org/Misc/features.html#clean-design, clean code
is quite important fot NetBSD.

If there's some optimization or other issues here, let me know.
If it's a matter of religious wars, well, I'll be happy to know too :)
And if it's a matter of finding  someone to make the change, again, let me know.

Thanks
    Ofer Waldman