* [9fans] acme suicide
@ 2004-03-08 19:27 Noah Evans
2004-03-09 5:28 ` rob pike, esq.
0 siblings, 1 reply; 15+ messages in thread
From: Noah Evans @ 2004-03-08 19:27 UTC (permalink / raw)
To: 9fans
I tried 'Edit , | man 2 9p' in the tag of an acme window and got:
panic: D2B called on non-block 11a8c8 (double-free?)
acme 1436: suicide: sys: trap: fault read addr=0x0 pc=0x0003aed5
and for fun:
acid: stk()
abort()+0x0 /sys/src/libc/9sys/abort.c:6
ppanic(p=0x472a0,fmt=0x48314)+0x152 /sys/src/libc/port/malloc.c:158
D2B(v=0x11a8c8,p=0x472a0)+0x32 /sys/src/libc/port/pool.c:943
poolreallocl(ndsize=0x3192,v=0x11a8c8,p=0x472a0)+0x47 /sys/src/libc/port/pool.c:994
poolrealloc(p=0x472a0,v=0x11a8c8,n=0x3192)+0x49 /sys/src/libc/port/pool.c:1151
realloc(size=0x318a,v=0x11a8c8)+0x4d /sys/src/libc/port/malloc.c:245
erealloc(p=0x11a8d0,n=0x318a)+0x17 /sys/src/cmd/acme/util.c:367
sizecache(n=0x1861,b=0x958f0)+0x32 /sys/src/cmd/acme/buff.c:26
bufinsert(b=0x958f0,q0=0x3024,n=0x1861,s=0x118890)+0x2cb /sys/src/cmd/acme/buff.c:168
elogflush(f=0xace50)+0x97 /sys/src/cmd/acme/elog.c:113
elogapply(f=0xace50)+0xf /sys/src/cmd/acme/elog.c:225
allupdate(w=0xcbf18)+0x7e /sys/src/cmd/acme/edit.c:121
allwindows(arg=0x0,f=0xacd7)+0x4e /sys/src/cmd/acme/rows.c:718
editcmd(n=0xc,r=0xc3792,ct=0xcbf2c)+0x1a4 /sys/src/cmd/acme/edit.c:189
edit(et=0xcbf2c,argt=0x0,arg=0xc3792,narg=0xc)+0x8c /sys/src/cmd/acme/exec.c:821
execute(t=0xcbf2c,aq0=0x21,aq1=0x21,external=0x0,argt=0x0)+0x1ec /sys/src/cmd/acme/exec.c:190
mousethread()+0x49d /sys/src/cmd/acme/acme.c:550
launcher386(arg=0x0,f=0x2276)+0x10 /sys/src/libthread/386.c:10
0xfefefefe ?file?:0
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [9fans] acme suicide
2004-03-09 6:09 ` David Tolpin
@ 2004-03-09 5:23 ` andrey mirtchovski
2004-03-09 6:31 ` David Tolpin
0 siblings, 1 reply; 15+ messages in thread
From: andrey mirtchovski @ 2004-03-09 5:23 UTC (permalink / raw)
To: 9fans
> I was asking about a port of patch. ape/patch is it, I simply
> did not know where to look.
if you're really twisted:
http://pages.cpsc.ucalgary.ca/~mirtchov/lanlp9/unix/patch-2.5.4.tar
diffutils and paste are also there. enjoy.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [9fans] acme suicide
2004-03-08 19:27 [9fans] acme suicide Noah Evans
@ 2004-03-09 5:28 ` rob pike, esq.
2004-03-09 5:38 ` David Tolpin
2004-03-09 13:44 ` David Presotto
0 siblings, 2 replies; 15+ messages in thread
From: rob pike, esq. @ 2004-03-09 5:28 UTC (permalink / raw)
To: 9fans
> I tried 'Edit , | man 2 9p' in the tag of an acme window and got:
>
> panic: D2B called on non-block 11a8c8 (double-free?)
> acme 1436: suicide: sys: trap: fault read addr=0x0 pc=0x0003aed5
this is kind of amazing. i was testing something for rsc and crashed acme.
tracked it down, fixed it. it was a day 1 bug; amazing it had never happened.
then i decided to track down your bug. turns out it's the same thing.
amazing coincidence.
here's the fix:
r% yesterday -d /sys/src/cmd/acme/elog.c
diff /n/dump/2004/0308/sys/src/cmd/acme/elog.c /sys/src/cmd/acme/elog.c
173c173
< if(f->elog.type==Insert && q0==f->elog.q0 && (q0+nr)-f->elog.q0<Maxstring){
---
> if(f->elog.type==Insert && q0==f->elog.q0 && f->elog.nr+nr<Maxstring){
r%
-rob
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [9fans] acme suicide
2004-03-09 5:28 ` rob pike, esq.
@ 2004-03-09 5:38 ` David Tolpin
2004-03-09 5:55 ` lucio
2004-03-09 6:06 ` rob pike, esq.
2004-03-09 13:44 ` David Presotto
1 sibling, 2 replies; 15+ messages in thread
From: David Tolpin @ 2004-03-09 5:38 UTC (permalink / raw)
To: 9fans
> 173c173
> < if(f->elog.type==Insert && q0==f->elog.q0 && (q0+nr)-f->elog.q0<Maxstring){
> ---
> > if(f->elog.type==Insert && q0==f->elog.q0 && f->elog.nr+nr<Maxstring){
Is there a program under Plan 9 that can apply this (or similar)
diff automatically?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [9fans] acme suicide
2004-03-09 5:38 ` David Tolpin
@ 2004-03-09 5:55 ` lucio
2004-03-09 6:06 ` rob pike, esq.
1 sibling, 0 replies; 15+ messages in thread
From: lucio @ 2004-03-09 5:55 UTC (permalink / raw)
To: 9fans
>> 173c173
>> < if(f->elog.type==Insert && q0==f->elog.q0 && (q0+nr)-f->elog.q0<Maxstring){
>> ---
>> > if(f->elog.type==Insert && q0==f->elog.q0 && f->elog.nr+nr<Maxstring){
>
> Is there a program under Plan 9 that can apply this (or similar)
> diff automatically?
ape/patch? With a little bit of assistance?
++L
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [9fans] acme suicide
2004-03-09 5:38 ` David Tolpin
2004-03-09 5:55 ` lucio
@ 2004-03-09 6:06 ` rob pike, esq.
2004-03-09 6:09 ` David Tolpin
1 sibling, 1 reply; 15+ messages in thread
From: rob pike, esq. @ 2004-03-09 6:06 UTC (permalink / raw)
To: 9fans
> Is there a program under Plan 9 that can apply this (or similar)
> diff automatically?
replica/pull, once the patch is on sources.
-rob
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [9fans] acme suicide
2004-03-09 6:06 ` rob pike, esq.
@ 2004-03-09 6:09 ` David Tolpin
2004-03-09 5:23 ` andrey mirtchovski
0 siblings, 1 reply; 15+ messages in thread
From: David Tolpin @ 2004-03-09 6:09 UTC (permalink / raw)
To: 9fans
>
> > Is there a program under Plan 9 that can apply this (or similar)
> > diff automatically?
>
> replica/pull, once the patch is on sources.
Yes, I understand it.
I was asking about a port of patch. ape/patch is it, I simply
did not know where to look.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [9fans] acme suicide
2004-03-09 5:23 ` andrey mirtchovski
@ 2004-03-09 6:31 ` David Tolpin
0 siblings, 0 replies; 15+ messages in thread
From: David Tolpin @ 2004-03-09 6:31 UTC (permalink / raw)
To: 9fans
> > I was asking about a port of patch. ape/patch is it, I simply
> > did not know where to look.
>
> if you're really twisted:
>
> http://pages.cpsc.ucalgary.ca/~mirtchov/lanlp9/unix/patch-2.5.4.tar
>
Thank you. Actually, gnu patch 2.5 in ape/patch is working.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [9fans] acme suicide
2004-03-09 5:28 ` rob pike, esq.
2004-03-09 5:38 ` David Tolpin
@ 2004-03-09 13:44 ` David Presotto
1 sibling, 0 replies; 15+ messages in thread
From: David Presotto @ 2004-03-09 13:44 UTC (permalink / raw)
To: 9fans
[-- Attachment #1: Type: text/plain, Size: 19 bytes --]
Fix now on sources.
[-- Attachment #2: Type: message/rfc822, Size: 2698 bytes --]
From: "rob pike, esq." <r@geekmail.cc>
To: 9fans@cse.psu.edu
Subject: Re: [9fans] acme suicide
Date: Mon, 8 Mar 2004 21:28:46 -0800
Message-ID: <36c13887672c32979c9849347bc8d07a@google.com>
> I tried 'Edit , | man 2 9p' in the tag of an acme window and got:
>
> panic: D2B called on non-block 11a8c8 (double-free?)
> acme 1436: suicide: sys: trap: fault read addr=0x0 pc=0x0003aed5
this is kind of amazing. i was testing something for rsc and crashed acme.
tracked it down, fixed it. it was a day 1 bug; amazing it had never happened.
then i decided to track down your bug. turns out it's the same thing.
amazing coincidence.
here's the fix:
r% yesterday -d /sys/src/cmd/acme/elog.c
diff /n/dump/2004/0308/sys/src/cmd/acme/elog.c /sys/src/cmd/acme/elog.c
173c173
< if(f->elog.type==Insert && q0==f->elog.q0 && (q0+nr)-f->elog.q0<Maxstring){
---
> if(f->elog.type==Insert && q0==f->elog.q0 && f->elog.nr+nr<Maxstring){
r%
-rob
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [9fans] Acme suicide
2005-10-27 10:44 [9fans] Acme suicide Uriel
@ 2005-10-27 13:28 ` Russ Cox
0 siblings, 0 replies; 15+ messages in thread
From: Russ Cox @ 2005-10-27 13:28 UTC (permalink / raw)
To: Fans of the OS Plan 9 from Bell Labs
> Logged in with dt2k(latest from CVS), which so far has been rock solid.
Try logging in without starting rio and then cat /lib/gettysburg.
Russ
^ permalink raw reply [flat|nested] 15+ messages in thread
* [9fans] Acme suicide
@ 2005-10-27 10:44 Uriel
2005-10-27 13:28 ` Russ Cox
0 siblings, 1 reply; 15+ messages in thread
From: Uriel @ 2005-10-27 10:44 UTC (permalink / raw)
To: Fans of the OS Plan 9 from Bell Labs
Acme suicided when I executed "Edit x/^/c/* /" in a tag bar.
acme: no window owner: '.../genpunc.9.0' does not exist
acme 149313: suicide: sys: trap: fault read addr=0x0 pc=0x0003b286
Logged in with dt2k(latest from CVS), which so far has been rock solid.
uriel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [9fans] acme suicide
2005-03-18 17:46 Sam
@ 2005-03-18 18:09 ` Russ Cox
0 siblings, 0 replies; 15+ messages in thread
From: Russ Cox @ 2005-03-18 18:09 UTC (permalink / raw)
To: Fans of the OS Plan 9 from Bell Labs
i'm pretty sure this is a bug rob fixed a month
ago and i neglected to apply. fixing now.
russ
^ permalink raw reply [flat|nested] 15+ messages in thread
* [9fans] acme suicide
@ 2005-03-18 17:46 Sam
2005-03-18 18:09 ` Russ Cox
0 siblings, 1 reply; 15+ messages in thread
From: Sam @ 2005-03-18 17:46 UTC (permalink / raw)
To: 9fans
I just had acme suicide while editing a file -- some voodoo
combination of backspace, right arrow, and shift, I think.
Tiny keyboard, fat palm. :)
acme: text.type backspace: couldn't find destination for message
acme 354384: suicide: sys: trap: fault read addr=0x0 pc-0x0003adb5
Anyone interested in a snap to debug this further?
Cheers,
Sam
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [9fans] acme suicide
2004-03-09 13:48 Noah Evans
@ 2004-03-12 18:08 ` Rob Pike
0 siblings, 0 replies; 15+ messages in thread
From: Rob Pike @ 2004-03-12 18:08 UTC (permalink / raw)
To: 9fans
this is a stupid error. an assertion failure should be reduced to a
warning.
/sys/src/cmd/acme/text.c:194,195 should be replaced by:
if(t->ncache!=0 || t->file->b.nc || t->w==nil || t!=&t->w->body)
error("text.load");
if(t->w->isdir && t->file->nname==0){
warning(nil, "empty directory name\n");
return 0;
}
in short, move the check for empty directory name out of the test for
error.
-rob
On Mar 9, 2004, at 5:48 AM, Noah Evans wrote:
> Awesome! another thing, have you ever tried to "Get" a nil string(when
> you deleted the previous filename)? It's no biggie because I know to
> avoid the error, but it might be interesting nevertheless.
>
> Noah
>
> acme: text.load: 'Del' file does not exist
> acme 5965: suicide: sys: trap: fault read addr=0x0 pc=0x0003aecd
>
> acid: stk()
> abort()+0x0 /sys/src/libc/9sys/abort.c:6
> error(s=0x4136c)+0x33 /sys/src/cmd/acme/util.c:55
> textload(t=0x82648,file=0x99d68,q0=0x0,setqid=0x1)+0x2c
> /sys/src/cmd/acme/text.c:193
> get(et=0x8256c,flag1=0x1,t=0x82648,argt=0x0,arg=0x833de,narg=0x0)+0x1fe
> /sys/src/cmd/acme/exec.c:497
> execute(t=0x8256c,aq0=0xc,aq1=0xc,external=0x0,argt=0x0)+0x1ec
> /sys/src/cmd/acme/exec.c:190
> mousethread()+0x49d /sys/src/cmd/acme/acme.c:550
> launcher386(arg=0x0,f=0x2276)+0x10 /sys/src/libthread/386.c:10
> 0xfefefefe ?file?:0
>
> ----- Original Message -----
> From: "rob pike, esq." <r@geekmail.cc>
> Date: Tuesday, March 9, 2004 0:28 am
> Subject: Re: [9fans] acme suicide
>
>>> I tried 'Edit , | man 2 9p' in the tag of an acme window and got:
>>>
>>> panic: D2B called on non-block 11a8c8 (double-free?)
>>> acme 1436: suicide: sys: trap: fault read addr=0x0 pc=0x0003aed5
>>
>> this is kind of amazing. i was testing something for rsc and
>> crashed acme.
>> tracked it down, fixed it. it was a day 1 bug; amazing it had
>> never happened.
>> then i decided to track down your bug. turns out it's the same thing.
>> amazing coincidence.
>>
>> here's the fix:
>>
>> r% yesterday -d /sys/src/cmd/acme/elog.c
>> diff /n/dump/2004/0308/sys/src/cmd/acme/elog.c
>> /sys/src/cmd/acme/elog.c173c173
>> < if(f->elog.type==Insert && q0==f->elog.q0 && (q0+nr)-f-
>>> elog.q0<Maxstring){---
>>> if(f->elog.type==Insert && q0==f->elog.q0 && f-
>>> elog.nr+nr<Maxstring){r%
>>
>> -rob
>>
>>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [9fans] acme suicide
@ 2004-03-09 13:48 Noah Evans
2004-03-12 18:08 ` Rob Pike
0 siblings, 1 reply; 15+ messages in thread
From: Noah Evans @ 2004-03-09 13:48 UTC (permalink / raw)
To: 9fans
Awesome! another thing, have you ever tried to "Get" a nil string(when you deleted the previous filename)? It's no biggie because I know to avoid the error, but it might be interesting nevertheless.
Noah
acme: text.load: 'Del' file does not exist
acme 5965: suicide: sys: trap: fault read addr=0x0 pc=0x0003aecd
acid: stk()
abort()+0x0 /sys/src/libc/9sys/abort.c:6
error(s=0x4136c)+0x33 /sys/src/cmd/acme/util.c:55
textload(t=0x82648,file=0x99d68,q0=0x0,setqid=0x1)+0x2c /sys/src/cmd/acme/text.c:193
get(et=0x8256c,flag1=0x1,t=0x82648,argt=0x0,arg=0x833de,narg=0x0)+0x1fe /sys/src/cmd/acme/exec.c:497
execute(t=0x8256c,aq0=0xc,aq1=0xc,external=0x0,argt=0x0)+0x1ec /sys/src/cmd/acme/exec.c:190
mousethread()+0x49d /sys/src/cmd/acme/acme.c:550
launcher386(arg=0x0,f=0x2276)+0x10 /sys/src/libthread/386.c:10
0xfefefefe ?file?:0
----- Original Message -----
From: "rob pike, esq." <r@geekmail.cc>
Date: Tuesday, March 9, 2004 0:28 am
Subject: Re: [9fans] acme suicide
> > I tried 'Edit , | man 2 9p' in the tag of an acme window and got:
> >
> > panic: D2B called on non-block 11a8c8 (double-free?)
> > acme 1436: suicide: sys: trap: fault read addr=0x0 pc=0x0003aed5
>
> this is kind of amazing. i was testing something for rsc and
> crashed acme.
> tracked it down, fixed it. it was a day 1 bug; amazing it had
> never happened.
> then i decided to track down your bug. turns out it's the same thing.
> amazing coincidence.
>
> here's the fix:
>
> r% yesterday -d /sys/src/cmd/acme/elog.c
> diff /n/dump/2004/0308/sys/src/cmd/acme/elog.c
> /sys/src/cmd/acme/elog.c173c173
> < if(f->elog.type==Insert && q0==f->elog.q0 && (q0+nr)-f-
> >elog.q0<Maxstring){---
> > if(f->elog.type==Insert && q0==f->elog.q0 && f-
> >elog.nr+nr<Maxstring){r%
>
> -rob
>
>
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2005-10-27 13:28 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-08 19:27 [9fans] acme suicide Noah Evans
2004-03-09 5:28 ` rob pike, esq.
2004-03-09 5:38 ` David Tolpin
2004-03-09 5:55 ` lucio
2004-03-09 6:06 ` rob pike, esq.
2004-03-09 6:09 ` David Tolpin
2004-03-09 5:23 ` andrey mirtchovski
2004-03-09 6:31 ` David Tolpin
2004-03-09 13:44 ` David Presotto
2004-03-09 13:48 Noah Evans
2004-03-12 18:08 ` Rob Pike
2005-03-18 17:46 Sam
2005-03-18 18:09 ` Russ Cox
2005-10-27 10:44 [9fans] Acme suicide Uriel
2005-10-27 13:28 ` Russ Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).