9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: Einar Karttunen <ekarttun@cs.helsinki.fi>
To: Plan9 ML <9fans@cse.psu.edu>
Subject: [9fans] Common code - isatty
Date: Wed, 13 Apr 2005 16:20:42 +0300	[thread overview]
Message-ID: <20050413132042.GA13385@melkki.cs.Helsinki.FI> (raw)

Hello

While reading source code I noticed several different isatty
implementations. They are slightly different and I would be interested
in 1) which is the correct implementation and 2) whether a patch
to fix the others would be welcome and whether a common location 
in a library or cut-paste is preferred.

The locations include at least:
ape/lib/ap/isatty.c      - check whether fd2path ends in "/dev/cons"
cmd/ip/telnet.c          - dirstat -> "cons"
cmd/rc/plan9.c           - dirstat -> "ptty" or same dev,type,qid as "/dev/cons"
cmd/ssh/ssh.c            - fd2path ends in "/dev/cons"
cmd/upas/common/libsys.c - dirstat -> "cons"
libstdio/setvbuf.c       - dirstat -> same dev,type and qid as "/dev/cons"

- Einar Karttunen


             reply	other threads:[~2005-04-13 13:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-13 13:20 Einar Karttunen [this message]
2005-04-13 21:50 ` Russ Cox
2005-04-13 23:26   ` Ronald G. Minnich
2005-04-13 23:52     ` Dan Cross
2005-04-13 23:57       ` boyd, rounin
2005-04-14  0:00         ` Russ Cox
2005-04-14  0:14           ` boyd, rounin
2005-04-14  0:18             ` Russ Cox
2005-04-14  0:22               ` Bruce Ellis
2005-04-14  0:38                 ` Dan Cross
2005-04-14  1:02                   ` boyd, rounin
2005-04-14  0:56                 ` jmk
2005-04-14  0:01       ` Bruce Ellis
2005-04-14  0:39         ` Dan Cross
2005-04-14 17:14         ` Ronald G. Minnich
2005-04-14 17:29           ` Rob Pike
2005-04-14 19:25             ` Ronald G. Minnich
2005-04-14 23:23             ` Bruce Ellis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050413132042.GA13385@melkki.cs.Helsinki.FI \
    --to=ekarttun@cs.helsinki.fi \
    --cc=9fans@cse.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).