From: "Russ Cox" <rsc@swtch.com>
To: 9fans@cse.psu.edu
Subject: Re: [9fans] taslock.c change.
Date: Tue, 1 May 2007 17:12:50 -0400 [thread overview]
Message-ID: <20070501211252.B26191E8C26@holo.morphisms.net> (raw)
In-Reply-To: <22db92ac16a19d45bb908c72a57696a5@coraid.com>
> taslock.c:145,153 - /n/sources/ plan9/sys/src/9/port//taslock.c:145,150
> panic("corrupt ilock %p pc=%luX m=%p isilock=%d",
> l, l->pc, l->m, l->isilock);
> }
> - if(l->m == MACHP(m->machno))
> - panic("ilock: deadlock on cpu%d pc=%luX lockpc=%luX\n",
> - m->machno, pc, l->pc);
> for(;;){
> lockstats.inglare++;
> splx(x);
i removed them because they contradicted the
comment a few lines up:
/*
* Cannot also check l->pc and l->m here because
* they might just not be set yet, or the lock might
* even have been let go.
*/
and so i thought the deadlock message i was getting
was actually incorrect.
it should go back, i suppose -- my problem turned
out that the deadlock message was mostly correct
and that some stray kernel code was scribbling on
other people's memory. but if it does go back
the coherence lines in iunlock should move up one
statement, i believe.
russ
prev parent reply other threads:[~2007-05-01 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 20:58 erik quanstrom
2007-05-01 21:12 ` Russ Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070501211252.B26191E8C26@holo.morphisms.net \
--to=rsc@swtch.com \
--cc=9fans@cse.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).