From: "Russ Cox" <rsc@swtch.com>
To: 9fans@cse.psu.edu
Subject: Re: [9fans] page and plumbing
Date: Sun, 30 Sep 2007 14:46:00 -0400 [thread overview]
Message-ID: <20070930184603.9AFA81E8C22@holo.morphisms.net> (raw)
In-Reply-To: <20070926080547.GA4978@shodan.homeunix.net>
> After a pull two days ago I noticed that plumbing images to page does not
> work any more. Page still starts but exits immediately before displaying
> anything. Starting page manually works as expected. As postscript and pdf
> files as well as other plumbing targets are unaffected led me to to suspect
> the new image handling code somehow interfers with plumbing.
True enough. Here is a better solution:
cpu% diff -c /n/sources/plan9//sys/src/cmd/page/cache.c /sys/src/cmd/page/cache.c
/n/sources/plan9//sys/src/cmd/page/cache.c:151,156 - /sys/src/cmd/page/cache.c:151,159
Image *im;
int ra;
+ if(doc->npage < 1)
+ return display->white;
+
im = _cachedpage(doc, angle, page, "");
if(im == nil)
return nil;
cpu%
Sorry about that -- I'd forgotten about -i,
which has always been a hack.
I've submitted this as a patch.
It is unfortunately not related to
Greg Pavelcak's problems, which
I have not been able to reproduce.
The new page works fine for me in
drawterm. That sounds like drawterm
is running out of image memory
somehow, but I don't see how, and
even if it did it should be behaving
more gracefully.
Russ
prev parent reply other threads:[~2007-09-30 18:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 8:05 Martin Neubauer
2007-09-30 18:46 ` Russ Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070930184603.9AFA81E8C22@holo.morphisms.net \
--to=rsc@swtch.com \
--cc=9fans@cse.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).