From mboxrd@z Thu Jan  1 00:00:00 1970
From: Artem Pylypchuk <articice@ua.fm>
To: 9fans@9fans.net
Date: Tue, 23 Feb 2010 12:29:12 +0200
User-Agent: KMail/1.9.9
References: <mailman.10146.1266886523.1513.9fans@9fans.net>
In-Reply-To: <mailman.10146.1266886523.1513.9fans@9fans.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <201002231229.13030.articice@ua.fm>
Subject: Re: [9fans] pppoe on Plan 9
Topicbox-Message-UUID: d8aaf1de-ead5-11e9-9d60-3106f5b1d025


> Date: Mon, 22 Feb 2010 16:13:59 -0800
> From: Russ Cox <rsc@swtch.com>
> Subject: Re: [9fans] pppoe on Plan 9
> To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net>
> Message-ID:
> 	<dd6fe68a1002221613h4c6597abkfb3cdd8a79f7a739@mail.gmail.com>
> Content-Type: text/plain; charset=UTF-8
>
> > 00304894958d -> 00508d68c9c0 type 0x8863
> > ? ? ? ?vers 1 type 1 code 0x7 sessid 0x0 length 63
> > ? ? ? ?0x102 22: ac 'pecs-nas1.tvnetwork.hu'
> > ? ? ? ?0x101 9: service 'TvNetWork'
> > ? ? ? ?0x104 20: ac cookie 31e0aff8b09a633faae5b9685fdfbd0dad000000
> > dropping unwanted pkt: no matching service name
>
> try adding
>      -S TvNetWork
> to your command line.
>
> it looks like in pppoe.c the block
>
> 	if((s = findtag(pkt, TagSrvName, &len, 0)) == nil)
> 		return bad("no matching service name");
> 	if(len != strlen(srvname) || memcmp(s, srvname, len) != 0)
> 		return bad("no matching service name");
>
> should be inside a if(srvname[0] != '\0') { ... }.

this is because the PPPoE RFC defines strings "provider name/access
concentrator" and "service name" in service offer packets, in case you have
lots of providers and different connections in your network. The services may
include different payment packages, special line for voip/video, a VPN, etc.
Offers are collected after a request broadcast.