From: tlaronde@polynum.com
To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net>
Subject: Re: [9fans] BUG: disk/fdisk.c: corrupts MBR
Date: Sat, 7 Jan 2012 20:22:13 +0100 [thread overview]
Message-ID: <20120107192213.GA4971@polynum.com> (raw)
In-Reply-To: <1c3ba45416e47236eedd6ca05863d751@chula.quanstro.net>
On Sat, Jan 07, 2012 at 02:04:51PM -0500, erik quanstrom wrote:
> On Sat Jan 7 13:30:33 EST 2012, tlaronde@polynum.com wrote:
> > The explanation is arithmetic truncation. disk/fdisk.c does this:
> >
> > p->start = lba/sec2cyl;
> >
> > and, if modifications are done (for example creating a Plan9 partition,
> > of marking a primary partition active), when written back, the entries
> > are "restored" by:
> >
> > *endlba = (vlong)p->start*sec2cyl;
> >
> can you just set sec2cyl=1?
This wouls probably do the trick. But the code is clean and setting just
this is not---to my taste.
The ideal would be to simply patch the existing with changed values (no
need to be efficient for 4 * 16 bytes), and leave clearly alone values
set by others.
And to verify the magic signature for, at least, the active partition
(it would have spot the problem).
--
Thierry Laronde <tlaronde +AT+ polynum +dot+ com>
http://www.kergis.com/
Key fingerprint = 0FF7 E906 FBAF FE95 FD89 250D 52B1 AE95 6006 F40C
next prev parent reply other threads:[~2012-01-07 19:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 18:29 tlaronde
2012-01-07 19:04 ` erik quanstrom
2012-01-07 19:22 ` tlaronde [this message]
2012-01-07 19:30 ` erik quanstrom
2012-01-07 20:13 ` tlaronde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120107192213.GA4971@polynum.com \
--to=tlaronde@polynum.com \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).