From: David du Colombier <0intro@gmail.com>
To: 9fans@9fans.net
Subject: Re: [9fans] Go tip build fails
Date: Wed, 1 May 2013 21:18:57 +0200 [thread overview]
Message-ID: <20130501211857.02f03574@zinc.9fans.fr> (raw)
In-Reply-To: <ECFE66DD-7B53-406F-AF8A-52CB35A7DFA0@gmail.com>
> in the ld directory, look for assignments to rd->add from calls to
> e32. two do not do a cast to int32. try casting those two and let me
> know if you can
I made this change and it doesn't seem to fix the problem.
diff -r 3478ecc801f6 src/cmd/ld/ldelf.c
--- a/src/cmd/ld/ldelf.c Wed May 01 10:00:05 2013 -0400
+++ b/src/cmd/ld/ldelf.c Wed May 01 19:15:00 2013 +0000
@@ -706,7 +706,7 @@
else {
// load addend from image
if(rp->siz == 4)
- rp->add = e->e32(sect->base+rp->off);
+ rp->add = (int32)e->e32(sect->base+rp->off);
else if(rp->siz == 8)
rp->add = e->e64(sect->base+rp->off);
else
diff -r 3478ecc801f6 src/cmd/ld/ldpe.c
--- a/src/cmd/ld/ldpe.c Wed May 01 10:00:05 2013 -0400
+++ b/src/cmd/ld/ldpe.c Wed May 01 19:15:00 2013 +0000
@@ -297,7 +297,7 @@
case IMAGE_REL_I386_DIR32:
rp->type = D_ADDR;
// load addend from image
- rp->add = le32(rsect->base+rp->off);
+ rp->add = (int32)le32(rsect->base+rp->off);
break;
case IMAGE_REL_AMD64_ADDR64: // R_X86_64_64
rp->siz = 8;
--
David du Colombier
next prev parent reply other threads:[~2013-05-01 19:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 17:55 Skip Tavakkolian
2013-05-01 18:11 ` Rob Pike
2013-05-01 18:20 ` Jacob Todd
2013-05-01 18:31 ` Skip Tavakkolian
2013-05-01 18:54 ` Rob Pike
2013-05-01 19:14 ` Skip Tavakkolian
2013-05-01 19:25 ` Skip Tavakkolian
2013-05-01 19:59 ` Matthew Veety
2013-05-01 20:46 ` Russ Cox
2013-05-01 20:49 ` Jacob Todd
2013-05-01 20:58 ` Skip Tavakkolian
2013-05-01 21:32 ` Rob Pike
2013-05-01 20:46 ` Rob Pike
2013-05-01 19:18 ` David du Colombier [this message]
2013-05-01 18:30 ` David du Colombier
2013-05-01 18:56 ` Skip Tavakkolian
2013-05-01 22:41 ` Rob Pike
2013-05-01 18:26 sl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130501211857.02f03574@zinc.9fans.fr \
--to=0intro@gmail.com \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).