9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: dexen deVries <dexen.devries@gmail.com>
To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net>
Subject: Re: [9fans] devdraw memory corruption
Date: Tue, 14 Jan 2014 01:43:01 -0800	[thread overview]
Message-ID: <2933109.dAW36glpQb@coil> (raw)
In-Reply-To: <2e748c14611ecd8e653a1865598e418d@felloff.net>

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]

On Tuesday 14 of January 2014 00:44:47 cinap_lenrek@felloff.net wrote:
> when user does read of exactly 12*12 bytes on draw
> ctl file, the snprint() adds one more \0 byte writing
> beyond the user buffer and corrupting memory.

what symptoms were you getting?

i'm seeing rare, seemingly random glitches in plan9port Acme.

some windows get only partially re-drawn -- any combination of borders, 
background and text can be missing, as per attachment. the top right window 
should be showing file list, but only background was drawn.


i've ported this patch to p9p to see if the breakage stops.

-- 
dexen deVries

[[[↓][→]]]

[-- Attachment #2: borken-acme.png --]
[-- Type: image/png, Size: 28357 bytes --]

      parent reply	other threads:[~2014-01-14  9:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-13 23:44 cinap_lenrek
2014-01-13 23:54 ` cinap_lenrek
2014-01-13 23:54 ` erik quanstrom
2014-01-14  9:43 ` dexen deVries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2933109.dAW36glpQb@coil \
    --to=dexen.devries@gmail.com \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).