From: quanstro@labs.coraid.com (erik quanstrom)
Subject: [9fans] diff problem
Date: Tue, 29 Mar 2011 14:58:04 -0400 [thread overview]
Message-ID: <2a76b6c332c18a765554a3187a55ab0c@coraid.com> (raw)
In-Reply-To: <AANLkTinjoec7xceqaEGEQmnfV=W8ftDZRVbqPHW8Jf83@mail.gmail.com>
> So I guess I must change BUF and MAXLINELEN. But shouldn't these
> defines be ideally at one place?; also they have no comments... :(
> Wouldn't it be nice to have the limits mentioned (automatically, say
> during compilation process) in the man page? Or, would it be difficult
> to get rid of any such limits?
i didn't spend much time looking at the code, but if you really care,
i would recommend reading a line-at-a-time into a malloc'd buffer.
malloc is slow, but not slow enough to matter.
it might be worth fixing, but any such fix shouldn't result in more
complicated code, or yet-another constant.
- erik
prev parent reply other threads:[~2011-03-29 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 15:08 Rudolf Sykora
2011-03-29 16:45 ` erik quanstrom
2011-03-29 17:28 ` Rudolf Sykora
2011-03-29 18:58 ` erik quanstrom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a76b6c332c18a765554a3187a55ab0c@coraid.com \
--to=quanstro@labs.coraid.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).