From mboxrd@z Thu Jan 1 00:00:00 1970 From: quanstro@labs.coraid.com (erik quanstrom) Date: Tue, 29 Mar 2011 14:58:04 -0400 Subject: [9fans] diff problem In-Reply-To: References: <3718da369f132a3a0c357b336e012eb1@coraid.com> Message-ID: <2a76b6c332c18a765554a3187a55ab0c@coraid.com> Topicbox-Message-UUID: c357fb0a-ead6-11e9-9d60-3106f5b1d025 > So I guess I must change BUF and MAXLINELEN. But shouldn't these > defines be ideally at one place?; also they have no comments... :( > Wouldn't it be nice to have the limits mentioned (automatically, say > during compilation process) in the man page? Or, would it be difficult > to get rid of any such limits? i didn't spend much time looking at the code, but if you really care, i would recommend reading a line-at-a-time into a malloc'd buffer. malloc is slow, but not slow enough to matter. it might be worth fixing, but any such fix shouldn't result in more complicated code, or yet-another constant. - erik