From mboxrd@z Thu Jan  1 00:00:00 1970
From: erik quanstrom <quanstro@quanstro.net>
Date: Tue,  8 Jan 2013 16:02:24 -0500
To: 9fans@9fans.net
Message-ID: <2d9133a4417c29256690480734bd5d69@brasstown.quanstro.net>
In-Reply-To: <CAG3N4d8Urjyhnw-08BvrER4a90J3+14EU+HrErtxU3kaKNp-NA@mail.gmail.com>
References: <CAG3N4d8Urjyhnw-08BvrER4a90J3+14EU+HrErtxU3kaKNp-NA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Subject: Re: [9fans] ape: getsockname: wrong byte order in sin_port
Topicbox-Message-UUID: 045c033e-ead8-11e9-9d60-3106f5b1d025

On Tue Jan  8 08:58:26 EST 2013, yarikos@gmail.com wrote:

> APE's getsockname() returns port with bytes swapped (on 386).
> Fix:
>
> /n/dump/2013/0108/sys/src/ape/lib/bsd/_sock_ingetaddr.c:35,41 -
> /sys/src/ape/lib/bsd/_sock_ingetaddr.c:35,41
>   if(p){
>   *p++ = 0;
>   ip->sin_family = AF_INET;
> - ip->sin_port = atoi(p);
> + ip->sin_port = htons(atoi(p));
>   ip->sin_addr.s_addr = inet_addr(name);
>   if(alen)
>   *alen = sizeof(struct sockaddr_in);
>
> Python needs to be relinked.

agree.  patch submitted.  /n/sources/patch/sin_port

- erik