From: cinap_lenrek@felloff.net
To: 9fans@9fans.net
Subject: [9fans] devproc noteid changing for none
Date: Thu, 2 Jan 2014 22:17:42 +0100 [thread overview]
Message-ID: <2e313dd33732518888ea58b070981c93@felloff.net> (raw)
one can change the note group of a process with devproc
by writing noteid file.
case Qnoteid:
id = atoi(a);
if(id == p->pid) {
p->noteid = id;
break;
}
t = proctab(0);
for(et = t+conf.nproc; t < et; t++) {
if(t->state == Dead)
continue;
if(id == t->noteid) {
if(strcmp(p->user, t->user) != 0)
error(Eperm);
p->noteid = id;
break;
}
}
if(p->noteid != id)
error(Ebadarg);
break;
the strcmp() check in that loop isnt enougth when the
user doing the write is "none" as this would allow him
to change the noteid of its process to another "none"
session and and then kill it. like for example to one
of the aux/listen procs.
the rules for "none" user is that he cant open other
processes running as "none" except its own calling
proc.
http://code.google.com/p/plan9front/source/detail?r=118280a79161c8cf42164bcc9458af7650652f91
--
cinap
next reply other threads:[~2014-01-02 21:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 21:17 cinap_lenrek [this message]
2014-01-02 21:22 ` erik quanstrom
2014-01-02 21:29 ` cinap_lenrek
2014-01-02 21:32 ` cinap_lenrek
2014-01-02 21:35 ` erik quanstrom
2014-01-02 21:41 ` cinap_lenrek
2014-01-02 21:43 ` erik quanstrom
2014-01-02 21:55 ` cinap_lenrek
2014-01-02 22:31 ` erik quanstrom
2014-01-02 22:47 ` erik quanstrom
2014-01-02 22:56 ` cinap_lenrek
2014-01-02 22:53 ` cinap_lenrek
2014-01-02 22:57 ` erik quanstrom
2014-01-02 23:01 ` cinap_lenrek
2014-01-02 23:04 ` erik quanstrom
2014-01-02 23:05 ` cinap_lenrek
2014-01-02 23:09 ` cinap_lenrek
2014-01-02 23:17 ` cinap_lenrek
2014-01-02 23:28 ` erik quanstrom
2014-01-03 0:23 ` erik quanstrom
2014-01-03 0:32 ` cinap_lenrek
2014-01-03 1:16 ` erik quanstrom
2014-01-03 1:23 ` cinap_lenrek
2014-01-03 1:31 ` erik quanstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e313dd33732518888ea58b070981c93@felloff.net \
--to=cinap_lenrek@felloff.net \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).