From: cinap_lenrek@felloff.net
To: 9fans@9fans.net
Subject: [9fans] devdraw memory corruption
Date: Tue, 14 Jan 2014 00:44:47 +0100 [thread overview]
Message-ID: <2e748c14611ecd8e653a1865598e418d@felloff.net> (raw)
when user does read of exactly 12*12 bytes on draw
ctl file, the snprint() adds one more \0 byte writing
beyond the user buffer and corrupting memory.
fix this by not snprint()ing the final space and add
it manually:
--- /sys/src/9/port/devdraw.c Wed Dec 25 13:55:16 2013 UTC
+++ /sys/src/9/port/devdraw.c Mon Jan 13 23:22:13 2014 UTC
@@ -1187,10 +1187,11 @@
error(Enodrawimage);
i = di->image;
}
- n =
sprint(a, "%11d %11d %11s %11d %11d %11d %11d %11d %11d %11d %11d %11d ",
+ n =
sprint(a, "%11d %11d %11s %11d %11d %11d %11d %11d %11d %11d %11d %11d",
cl->clientid, cl->infoid, chantostr(buf, i->chan),
(i->flags&Frepl)==Frepl,
i->r.min.x, i->r.min.y, i->r.max.x, i->r.max.y,
i->clipr.min.x, i->clipr.min.y, i->clipr.max.x, i->clipr.max.y);
+ ((char*)a)[n++] = ' ';
cl->infoid = -1;
break;
test program:
#include <u.h>
#include <libc.h>
#include <draw.h>
void
main(int argc, char *argv[])
{
char buf[12*12+1];
buf[12*12] = 'X';
if(read(0, buf, 12*12) != 12*12)
sysfatal("read: %r");
if(buf[12*12] != 'X')
sysfatal("corrupt");
}
term% ./8.out </dev/draw/new
corrupt
--
cinap
next reply other threads:[~2014-01-13 23:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 23:44 cinap_lenrek [this message]
2014-01-13 23:54 ` cinap_lenrek
2014-01-13 23:54 ` erik quanstrom
2014-01-14 9:43 ` dexen deVries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e748c14611ecd8e653a1865598e418d@felloff.net \
--to=cinap_lenrek@felloff.net \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).