From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <30374a40d728efddf1e4291f1f08a46a@proxima.alt.za>
To: 9fans@cse.psu.edu
From: Lucio De Re <lucio@proxima.alt.za>
Date: Mon,  6 Sep 2004 17:26:10 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Subject: [9fans] vncs - suicide
Topicbox-Message-UUID: de6af202-eacd-11e9-9e20-41e7f4b1d025

I have:

cpu% history /386/bin/vncs
Aug  7 05:35:01 SAT 2004 /386/bin/vncs 469227 [proxima]
Aug  7 05:35:01 SAT 2004 /n/dump/2004/0906/386/bin/vncs 469227 [proxima]
May 20 20:18:47 SAT 2004 /n/dump/2004/0807/386/bin/vncs 472667 [none]

and the newer version fails:

cpu% vncs
cpu% vncs 822: suicide: sys: trap: fault read addr=0x14 pc=0x0000b8b0
server started on display :1

although as the owner of the host (eve, in other words) I do not seem
to have the same problem.  Also, the previous version works quite
adequately.

Acid reports:

acid 822
/proc/822/text:386 plan 9 executable

/sys/lib/acid/port
/sys/lib/acid/386
acid: stk()
Exmkfid(fs=0x1ddad8,fid=0x2b3)+0x53 /sys/src/cmd/vnc/exportfs.c:441
Exattach(rpc=0x1e016c,fs=0x1ddad8)+0x66 /sys/src/cmd/vnc/exportfs.c:535
exslave()+0x46a /sys/src/cmd/vnc/exportfs.c:375
kproc(name=0x50095,a=0x0,f=0xb3cd)+0x65 /sys/src/cmd/vnc/compat.c:54
exportproc(fs=0x1ddad8)+0x186 /sys/src/cmd/vnc/exportfs.c:181
sysexport(fd=0x4,roots=0x1dcc98,nroots=0x3)+0x34 /sys/src/cmd/vnc/exportfs.c:111
extramp(v=0x7fffee78)+0x2c /sys/src/cmd/vnc/exporter.c:47
kproc(name=0x50c1c,a=0x7fffee78,f=0x96bf)+0x65 /sys/src/cmd/vnc/compat.c:54
exporter(dt=0x51244,sfd=0x3f020,fd=0x7fffef4c)+0x175 /sys/src/cmd/vnc/exporter.c:93
main(argv=0x7fffeeb8,argc=0x0)+0x2b2 /sys/src/cmd/vnc/vncs.c:186
_main+0x31 /sys/src/libc/386/main9.s:16
acid: 

but it's not clear to me why this happens as
/sys/src/cmd/vnc/exportfs.c:441 is the line highlighted below (in my
copy of the source, which ought to be up to date, but I suppose it
need not be):

	lock(&fs->fidlock);
	h = fid % Nfidhash;
	for(f = fs->fid[h]; f != nil; f = f->next){
>>>>>>>>>>>
		if(f->fid == fid){
<<<<<<<<<<<
			unlock(&fs->fidlock);
			free(nf);
			return nil;
		}
	}

Any suggestions?

++L