9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: erik quanstrom <quanstro@quanstro.net>
To: 9fans@9fans.net
Subject: [9fans] 9front sleep interrupted in kproc?
Date: Mon, 30 Dec 2013 12:43:21 -0500	[thread overview]
Message-ID: <3377fb7342a3ff404eae1ba724f11130@mikro> (raw)

not sure where to send this comment.

i think this patch misunderstands the situation.  the patch
claims that some code is wrong because sleep in a kproc might
get interrupted.

	http://code.google.com/p/plan9front/source/detail?r=3864ff1fe83f254622e6f10925f53df62255336d

this diff highlights the issue

	http://code.google.com/p/plan9front/source/diff?spec=svn3864ff1fe83f254622e6f10925f53df62255336d&r=3864ff1fe83f254622e6f10925f53df62255336d&format=side&path=/sys/src/9/port/alarm.c

the crux of the matter is when sleep might be interrupted.  sleep
is interrupted iff process received a note.

since kprocs don't get notes (it's an error to write to the note file),
sleep in a kproc can't get interrupted.  this code will never fire.

- erik



             reply	other threads:[~2013-12-30 17:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30 17:43 erik quanstrom [this message]
2013-12-31  1:06 ` Anthony Martin
2013-12-31  1:24   ` Anthony Martin
2013-12-31  4:40     ` erik quanstrom
2013-12-31 13:17       ` cinap_lenrek
2013-12-31 14:38         ` erik quanstrom
2013-12-31 10:55     ` Charles Forsyth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3377fb7342a3ff404eae1ba724f11130@mikro \
    --to=quanstro@quanstro.net \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).