From: cinap_lenrek@felloff.net
To: 9fans@9fans.net
Subject: Re: [9fans] Git and heritage (Was: Software preservation in the post-hg era)
Date: Sat, 4 Apr 2020 18:15:37 +0200 [thread overview]
Message-ID: <34FEFC835BD5D28B15D77593712E30C0@felloff.net> (raw)
In-Reply-To: <CAJQ9t7gfY_0AYyVYL9WUVAWsGwh9CL254CJ+xuu-Nh984zH_Zg@mail.gmail.com>
> I've attached the two patch sets, I make no claim to being a great
> coder, the focus was to make the changes (a) as clear as possible, (b)
> as unintrusive as possible.
- if(port == nil){
- port = "ssh";
- s = strchr(host, ':');
- if(s != nil){
- *s = '\0';
- port = s+1;
- }
- }
this breaks for ipv6 addresses. i'd suggest you at least check for ] first
and then look for the colon. example: "[::1]:22".
then the big question is what should be put in the thumb file to identify
the host, if you start messing with the network addresses. there can be
different ssh servers per port. for example: gerrit.
--
cinap
next prev parent reply other threads:[~2020-04-04 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 7:43 Lucio De Re
2020-04-04 16:15 ` cinap_lenrek [this message]
2020-04-05 17:44 ` Lucio De Re
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34FEFC835BD5D28B15D77593712E30C0@felloff.net \
--to=cinap_lenrek@felloff.net \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).