From: "rob pike, esq." <r@geekmail.cc>
To: 9fans@cse.psu.edu
Subject: Re: [9fans] acme suicide
Date: Mon, 8 Mar 2004 21:28:46 -0800 [thread overview]
Message-ID: <36c13887672c32979c9849347bc8d07a@google.com> (raw)
In-Reply-To: <f3b7bff415d0.f415d0f3b7bf@cwru.edu>
> I tried 'Edit , | man 2 9p' in the tag of an acme window and got:
>
> panic: D2B called on non-block 11a8c8 (double-free?)
> acme 1436: suicide: sys: trap: fault read addr=0x0 pc=0x0003aed5
this is kind of amazing. i was testing something for rsc and crashed acme.
tracked it down, fixed it. it was a day 1 bug; amazing it had never happened.
then i decided to track down your bug. turns out it's the same thing.
amazing coincidence.
here's the fix:
r% yesterday -d /sys/src/cmd/acme/elog.c
diff /n/dump/2004/0308/sys/src/cmd/acme/elog.c /sys/src/cmd/acme/elog.c
173c173
< if(f->elog.type==Insert && q0==f->elog.q0 && (q0+nr)-f->elog.q0<Maxstring){
---
> if(f->elog.type==Insert && q0==f->elog.q0 && f->elog.nr+nr<Maxstring){
r%
-rob
next prev parent reply other threads:[~2004-03-09 5:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-08 19:27 Noah Evans
2004-03-09 5:28 ` rob pike, esq. [this message]
2004-03-09 5:38 ` David Tolpin
2004-03-09 5:55 ` lucio
2004-03-09 6:06 ` rob pike, esq.
2004-03-09 6:09 ` David Tolpin
2004-03-09 5:23 ` andrey mirtchovski
2004-03-09 6:31 ` David Tolpin
2004-03-09 13:44 ` David Presotto
2004-03-09 13:48 Noah Evans
2004-03-12 18:08 ` Rob Pike
2005-03-18 17:46 Sam
2005-03-18 18:09 ` Russ Cox
2005-10-27 10:44 [9fans] Acme suicide Uriel
2005-10-27 13:28 ` Russ Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36c13887672c32979c9849347bc8d07a@google.com \
--to=r@geekmail.cc \
--cc=9fans@cse.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).