9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: erik quanstrom <quanstro@quanstro.net>
To: 9fans@9fans.net
Subject: [9fans] aux/acidleak pool pathology
Date: Thu, 21 May 2009 12:06:31 -0400	[thread overview]
Message-ID: <3d5d84f983b9566c6c007392f3c55ed4@quanstro.net> (raw)

without getting to deep in the details of the pool
library, the reallocation loop aux/acidleak sends
realloc off the deep end.

here's an example; i've added an abort so i can see
how big acidleak is getting

	rb2; ps -a | grep xyz
	xyz           15104    0:29   0:02    45132K Pread    fs [upas/fs -np]
	rb2; leak 15104
	aux/acidleak: realloc 12280320 fails
	acidleak 25325: suicide: sys: trap: fault read addr=0x0 pc=0x00004a14
	rb2; ps -a | grep leak
	xyz           25325    0:02   0:03  2022876K Broken   aux/acidleak
	xyz           25328    0:00   0:00      156K Pread    grep leak

obviously the Brdline loop in main is reallocating data and block
so they don't fit in their previous buckets and pool sbrk's more
memory.  it would seem that pool is missing the fact that
at some point the old, now-empty blocks are big enough
when merged.  however  libc/port/pool.c:/^poolreallocl
appears to have the proper logic.

- erik



             reply	other threads:[~2009-05-21 16:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-21 16:06 erik quanstrom [this message]
2009-05-21 16:35 ` Russ Cox
2009-05-21 16:54   ` erik quanstrom
2009-05-21 16:57     ` erik quanstrom
2009-05-21 17:19     ` Russ Cox
2009-05-21 18:04       ` erik quanstrom
2009-05-21 18:49         ` Russ Cox
2009-05-22  2:13           ` erik quanstrom
2009-05-22 16:52             ` Joel C. Salomon
2009-05-22 17:13               ` erik quanstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d5d84f983b9566c6c007392f3c55ed4@quanstro.net \
    --to=quanstro@quanstro.net \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).