From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <4279d553bf7bac8dd7104530d52ecf71@plan9.bell-labs.com>
From: David Presotto <presotto@closedmind.org>
To: 9fans@cse.psu.edu
Subject: Re: [9fans] acme suicide
In-Reply-To: <36c13887672c32979c9849347bc8d07a@google.com>
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="upas-pjypyiqdkhqzzdyritrcmchpzu"
Date: Tue,  9 Mar 2004 08:44:34 -0500
Topicbox-Message-UUID: 2589e9fa-eacd-11e9-9e20-41e7f4b1d025

This is a multi-part message in MIME format.
--upas-pjypyiqdkhqzzdyritrcmchpzu
Content-Disposition: inline
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit

Fix now on sources.
--upas-pjypyiqdkhqzzdyritrcmchpzu
Content-Type: message/rfc822
Content-Disposition: inline

Received: from plan9.cs.bell-labs.com ([135.104.9.2]) by plan9; Tue Mar  9 00:29:32 EST 2004
Received: from mail.cse.psu.edu ([130.203.4.6]) by plan9; Tue Mar  9 00:29:29 EST 2004
Received: by mail.cse.psu.edu (CSE Mail Server, from userid 60001)
	id B051319C0D; Tue,  9 Mar 2004 00:29:19 -0500 (EST)
Received: from psuvax1.cse.psu.edu (psuvax1.cse.psu.edu [130.203.4.6])
	by mail.cse.psu.edu (CSE Mail Server) with ESMTP
	id 0A5DF19D47; Tue,  9 Mar 2004 00:29:16 -0500 (EST)
X-Original-To: 9fans@cse.psu.edu
Delivered-To: 9fans@cse.psu.edu
Received: by mail.cse.psu.edu (CSE Mail Server, from userid 60001)
	id 493A519D3B; Tue,  9 Mar 2004 00:28:56 -0500 (EST)
Received: from 216-239-45-4.google.com (216-239-45-4.google.com [216.239.45.4])
	by mail.cse.psu.edu (CSE Mail Server) with ESMTP id 1FDF619C69
	for <9fans@cse.psu.edu>; Tue,  9 Mar 2004 00:28:55 -0500 (EST)
Received: from waakzaamheid (none@glenda.corp.google.com [172.24.64.198])
	by 216-239-45-4.google.com (8.12.9/8.12.9) with ESMTP id i295SkX6031971
	for <9fans@cse.psu.edu>; Mon, 8 Mar 2004 21:28:46 -0800
Message-ID: <36c13887672c32979c9849347bc8d07a@google.com>
To: 9fans@cse.psu.edu
Subject: Re: [9fans] acme suicide
From: "rob pike, esq." <r@geekmail.cc>
In-Reply-To: <f3b7bff415d0.f415d0f3b7bf@cwru.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Sender: 9fans-admin@cse.psu.edu
Errors-To: 9fans-admin@cse.psu.edu
X-BeenThere: 9fans@cse.psu.edu
X-Mailman-Version: 2.0.11
Precedence: bulk
Reply-To: 9fans@cse.psu.edu
List-Id: Fans of the OS Plan 9 from Bell Labs <9fans.cse.psu.edu>
List-Archive: <https://lists.cse.psu.edu/archives/9fans/>
Date: Mon, 8 Mar 2004 21:28:46 -0800
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on psuvax1.cse.psu.edu
X-Spam-Status: No, hits=-4.3 required=5.0 tests=RCVD_IN_BSP_TRUSTED 
	autolearn=no version=2.63
X-Spam-Level: 

> I tried 'Edit , | man 2 9p' in the tag of an acme window and got:
> 
> panic: D2B called on non-block 11a8c8 (double-free?)
> acme 1436: suicide: sys: trap: fault read addr=0x0 pc=0x0003aed5

this is kind of amazing. i was testing something for rsc and crashed acme.
tracked it down, fixed it.  it was a day 1 bug; amazing it had never happened.
then i decided to track down your bug.  turns out it's the same thing.
amazing coincidence.

here's the fix:

r% yesterday -d /sys/src/cmd/acme/elog.c
diff /n/dump/2004/0308/sys/src/cmd/acme/elog.c /sys/src/cmd/acme/elog.c
173c173
< 	if(f->elog.type==Insert && q0==f->elog.q0 && (q0+nr)-f->elog.q0<Maxstring){
---
> 	if(f->elog.type==Insert && q0==f->elog.q0 && f->elog.nr+nr<Maxstring){
r% 

-rob

--upas-pjypyiqdkhqzzdyritrcmchpzu--