Re: [9fans] Drawterm on Linux/PowerPC

[Sven Moritz Hallberg <sm@khjk.org>]

[-- Attachment #1.1: Type: text/plain, Size: 560 bytes --]

Eric Van Hensbergen schrieb:
> Essentially you were on the right path, but the wrong solution.
> man va_copy and look at the plan9ports fmtprint code for how to do
> this right on ppc/linux.

Hah, I'm such an idiot, overlooked va_copy although it's right in the
manpage. Anyway, I've replace the assignments with va_copy/va_end pairs,
as in plan9ports and drawterm seems to work! At least it compiles,
starts, and complains that I didn't tell it any server... :)

Attached is the output of cvs diff.


Thanks alot for the pointer,

Sven Moritz

[-- Attachment #1.2: drawterm-va_copy-patch.diff --]
[-- Type: text/x-patch, Size: 2624 bytes --]

Index: libc/fmtprint.c
===================================================================
RCS file: /cvs/drawterm/libc/fmtprint.c,v
retrieving revision 1.1
diff -r1.1 fmtprint.c
20c20,21
< 	va = f->args;
---
> 	va_copy(va, f->args);
> 	va_end(f->args);
27c28,29
< 	f->args = va;
---
> 	va_copy(f->args, va);
> 	va_end(va);
Index: libc/fmtvprint.c
===================================================================
RCS file: /cvs/drawterm/libc/fmtvprint.c,v
retrieving revision 1.1
diff -r1.1 fmtvprint.c
20,21c20,23
< 	va = f->args;
< 	f->args = args;
---
> 	va_copy(va, f->args);
> 	va_end(f->args);
> 	va_copy(f->args, args);
> 	va_end(args);
26c28,29
< 	f->args = va;
---
> 	va_copy(f->args, va);
> 	va_end(va);
Index: libc/runevseprint.c
===================================================================
RCS file: /cvs/drawterm/libc/runevseprint.c,v
retrieving revision 1.1
diff -r1.1 runevseprint.c
18c18,19
< 	f.args = args;
---
> 	va_copy(f.args, args);
> 	va_end(args);
Index: libc/runevsmprint.c
===================================================================
RCS file: /cvs/drawterm/libc/runevsmprint.c,v
retrieving revision 1.1
diff -r1.1 runevsmprint.c
60c60,61
< 	f.args = args;
---
> 	va_copy(f.args, args);
> 	va_end(args);
Index: libc/runevsnprint.c
===================================================================
RCS file: /cvs/drawterm/libc/runevsnprint.c,v
retrieving revision 1.1
diff -r1.1 runevsnprint.c
18c18,19
< 	f.args = args;
---
> 	va_copy(f.args, args);
> 	va_end(args);
Index: libc/vfprint.c
===================================================================
RCS file: /cvs/drawterm/libc/vfprint.c,v
retrieving revision 1.1
diff -r1.1 vfprint.c
29c29,30
< 	f.args = args;
---
> 	va_copy(f.args, args);
> 	va_end(args);
Index: libc/vseprint.c
===================================================================
RCS file: /cvs/drawterm/libc/vseprint.c,v
retrieving revision 1.1
diff -r1.1 vseprint.c
18c18,19
< 	f.args = args;
---
> 	va_copy(f.args, args);
> 	va_end(args);
Index: libc/vsmprint.c
===================================================================
RCS file: /cvs/drawterm/libc/vsmprint.c,v
retrieving revision 1.1
diff -r1.1 vsmprint.c
60c60,61
< 	f.args = args;
---
> 	va_copy(f.args, args);
> 	va_end(args);
Index: libc/vsnprint.c
===================================================================
RCS file: /cvs/drawterm/libc/vsnprint.c,v
retrieving revision 1.1
diff -r1.1 vsnprint.c
18c18,19
< 	f.args = args;
---
> 	va_copy(f.args, args);
> 	va_end(args);

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 264 bytes --]