From: "Lluís Batlle" <viriketo@gmail.com>
To: "Fans of the OS Plan 9 from Bell Labs" <9fans@cse.psu.edu>
Subject: Re: [9fans] Two ramfs?
Date: Mon, 4 Feb 2008 22:38:03 +0100 [thread overview]
Message-ID: <45219fb00802041338teb1a548i29b212643bf5a5d@mail.gmail.com> (raw)
In-Reply-To: <20080204203454.555AC1E8C35@holo.morphisms.net>
Thank you. I'll try to play with File and Tree now.
btw, I had some problems on /tmp due to free space, getting messages
from ./INSTALL as these:
...
copy.o: No space left on device
/tmp/cc2IGQH6.s: Assembler messages:
/tmp/cc2IGQH6.s:3059: FATAL: Can't write copy.o: Invalid argument
mk: 9c copy.c : exit status=exit(1)
mk: for i in ... : exit status=exit(1)
mk: for i in ... : exit status=exit(1)
...
nevertheless, the INSTALL script returned errorlevel 0.
I don't think this bothers many people, but I wasn't watching the
command output, and I trusted the errorlevel.
Regards.
2008/2/4, Russ Cox <rsc@swtch.com>:
> > I saw the src/cmd/ramfs.c, and I think I should be able to write mine
> > simpler... For example, I'd like to take advantage of the File/Tree
> > interface (createfile(), ...), having all the files of the fs in
> > memory.
> >
> > I found also src/lib9p/ramfs.c, which looks pretty much as what I
> > want, but this doesn't tollerate remounting well at all (I guess).
> >
> > I tried it with some modifications (to get it compiled) in plan9port
> > over linux (./ramfs -D -s test) and two "9p ls test" in a row makes
> > the server die.
> >
> > Where can I see an example of a working fileserver which uses File,
> > Tree, and the related functions?
>
> It's been a long time since I looked at that code, but it appears
> that the problem is that Tattach doesn't increment the reference
> count on its directory. Reattaching isn't very common in Plan 9
> (but is on p9p) so it's easy to believe this bug went unnoticed.
>
> Here is the fix, now in p9p:
>
> diff -r bcad073690c5 src/lib9p/srv.c
> --- a/src/lib9p/srv.c Fri Feb 01 07:54:19 2008 -0500
> +++ b/src/lib9p/srv.c Mon Feb 04 15:32:28 2008 -0500
> @@ -227,7 +227,7 @@ sattach(Srv *srv, Req *r)
> r->fid->uid = estrdup9p(r->ifcall.uname);
> if(srv->tree){
> r->fid->file = srv->tree->root;
> - /* BUG? incref(r->fid->file) ??? */
> + incref(&r->fid->file->ref);
> r->ofcall.qid = r->fid->file->dir.qid;
> r->fid->qid = r->ofcall.qid;
> }
>
> Russ
>
>
next prev parent reply other threads:[~2008-02-04 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-04 16:02 Lluís Batlle
2008-02-04 20:34 ` Russ Cox
2008-02-04 21:38 ` Lluís Batlle [this message]
2008-02-06 22:22 ` Lluís Batlle
2008-02-07 1:43 ` sqweek
2008-02-07 8:41 ` Lluís Batlle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45219fb00802041338teb1a548i29b212643bf5a5d@mail.gmail.com \
--to=viriketo@gmail.com \
--cc=9fans@cse.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).