9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: erik quanstrom <quanstro@labs.coraid.com>
To: 9fans@9fans.net
Subject: Re: [9fans] devdraw memory corruption
Date: Mon, 13 Jan 2014 18:54:57 -0500	[thread overview]
Message-ID: <45cd5ef279b7595da9771d7d494c7311@coraid.com> (raw)
In-Reply-To: <2e748c14611ecd8e653a1865598e418d@felloff.net>

> +++ /sys/src/9/port/devdraw.c	Mon Jan 13 23:22:13 2014 UTC
> @@ -1187,10 +1187,11 @@
>   				error(Enodrawimage);
>   			i = di->image;
>   		}
> -		n =
> sprint(a, "%11d %11d %11s %11d %11d %11d %11d %11d %11d %11d %11d %11d ",
> +		n =
> sprint(a, "%11d %11d %11s %11d %11d %11d %11d %11d %11d %11d %11d %11d",
>   			cl->clientid, cl->infoid, chantostr(buf, i->chan),
> (i->flags&Frepl)==Frepl,
>   			i->r.min.x, i->r.min.y, i->r.max.x, i->r.max.y,
>   			i->clipr.min.x, i->clipr.min.y, i->clipr.max.x, i->clipr.max.y);
> +		((char*)a)[n++] = ' ';
>   		cl->infoid = -1;
>   		break;

why not use a 145 byte buffer and readstr?

- erik



  parent reply	other threads:[~2014-01-13 23:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-13 23:44 cinap_lenrek
2014-01-13 23:54 ` cinap_lenrek
2014-01-13 23:54 ` erik quanstrom [this message]
2014-01-14  9:43 ` dexen deVries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45cd5ef279b7595da9771d7d494c7311@coraid.com \
    --to=quanstro@labs.coraid.com \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).