From mboxrd@z Thu Jan  1 00:00:00 1970
From: erik quanstrom <quanstro@coraid.com>
Date: Fri, 25 Sep 2009 14:32:05 -0400
To: 9fans@9fans.net
Message-ID: <466e12306dfbbfa15a65f17233b253e9@coraid.com>
In-Reply-To: <c9ec513f16d4318316f9c8d8883b6ca9@coraid.com>
References: <0394dacaee5cc8e182b6c87f23bd1c8f@brasstown.quanstro.net>
	<f75780240909251101l1fb7bf3drb52c1a5cdcf4f034@mail.gmail.com>
	<c9ec513f16d4318316f9c8d8883b6ca9@coraid.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Subject: Re: [9fans] segattach off-by-one?
Topicbox-Message-UUID: 7795f236-ead5-11e9-9d60-3106f5b1d025

the patch i posted yesterday was wrong.  i forgot about
automatic address assigment with segattach.  this works,
but perhaps it would be better to round va before checking
if va == 0?

/n/quanstro//sys/src/9/port/segment.c:642,648 - segment.c:642,648
  	Segment *s, *os;
  	Physseg *ps;

- 	if((va !=0 && va < BY2PG) || va >= USTKTOP)
+ 	if(va != 0 && va >= USTKTOP)
  		error(Ebadarg);

  	validaddr((ulong)name, 1, 0);

- erik