9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: jmk@plan9.bell-labs.com
To: 9fans@cse.psu.edu
Subject: Re: [9fans] ether8139.c fix
Date: Tue,  5 Mar 2002 10:26:46 -0500	[thread overview]
Message-ID: <47f44a52080aa0389afe9a45c25c2cd3@plan9.bell-labs.com> (raw)

On Tue Mar  5 05:08:09 EST 2002, north_@www.7f.no-ip.com wrote:
> > Line 494, in rtl8139receive(), reads
> > 
> > 				memmove(bp->rp, p, l);
> > but should be
> > 				memmove(bp->wp, p, l);
> > 
> > jmk has vetted this change.
> Good deal, but, which bug does this fix fix?
> Don (north_)
> http://www.7f.no-ip.com/

it fixes corrupting every packet which causes wrap-around
of the 64Kb receive buffer. it was fixed a long time ago but
i didn't realise the driver had been released without the
fix.


             reply	other threads:[~2002-03-05 15:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-05 15:26 jmk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-03-07 17:59 jmk
2002-03-07 14:08 presotto
2002-03-07 15:01 ` Boyd Roberts
2002-03-07  4:07 jmk
2002-03-07  4:07 Plan9
2002-03-07  3:14 geoff
2002-03-07  4:52 ` Jason Gurtz
2002-03-04  0:00 geoff
2002-03-05  9:40 ` Don

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47f44a52080aa0389afe9a45c25c2cd3@plan9.bell-labs.com \
    --to=jmk@plan9.bell-labs.com \
    --cc=9fans@cse.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).