9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: Jeff Sickel <jas@corpus-callosum.com>
To: Fans of the OS Plan 9 from Bell Labs <9fans@9fans.net>
Subject: [9fans] devdraw.c
Date: Fri, 26 Oct 2012 13:10:48 -0500	[thread overview]
Message-ID: <4EB96ED9-A826-495D-9A69-08161C314577@corpus-callosum.com> (raw)

I've been tracking down why the latest devdraw.c that includes winname just wasn't being read by rio in my drawterm-cocoa port.  What I found is that /dev/winname is created during the #i initialization but subsequently never found in drawgen() after the qid has been created from Qtopdir.  The following diff against the most recent Plan 9 sources versions of devdraw.c shows the change that lets drawterm resize the window and have rio pick up the change:

% diff /usr/local/src/plan9.bell-labs.com/plan9/sys/src/9/port/devdraw.c kern/devdraw.c
> drawgen(Chan *c, char *name, Dirtab *dt, int ndt, int s, Dir *dp)
218a219,222
> 	USED(name);
> 	USED(dt);
> 	USED(ndt);
> 
254c258
< 			mkqid(&q, Qwinname, 0, 0);
---
> 			mkqid(&q, Qwinname, 0, QTFILE);
262a267,272
> 	if(t == Qwinname){
> 			mkqid(&q, Qwinname, 0, QTFILE);
> 			devdir(c, q, "winname", 0, eve, 0444, dp);
> 			return 1;
> 	}
> 

These missing lines don't appear to be an issue in devvga.c or in the current 9vx.


Now that I've got clean resizing of a drawterm window working I'll be focused on cleaning up the rest of the diffs and pushing out a new version for OS X in the near term.

-jas




             reply	other threads:[~2012-10-26 18:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-26 18:10 Jeff Sickel [this message]
2012-10-26 20:20 ` cinap_lenrek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB96ED9-A826-495D-9A69-08161C314577@corpus-callosum.com \
    --to=jas@corpus-callosum.com \
    --cc=9fans@9fans.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).