From: cinap_lenrek@gmx.de
To: 9fans@9fans.net
Subject: Re: [9fans] dns
Date: Sun, 9 Sep 2012 00:27:04 +0200 [thread overview]
Message-ID: <518935cf94deb137205a6f672a01c3ee@rei2.9hal> (raw)
In-Reply-To: <CAJSxfmJczMAmhqQj7wBA_0fafExDUL9kR7R_-cVnSnz8PQqfcA@mail.gmail.com>
its pretty simple, just look where i made the <--- arrow in
my original post.
a patch would might look like this:
static int
fillinds(DS *ds, Dest *dp)
{
Conn *conn;
if (dp->winner < 0)
return -1;
conn = &dp->conn[dp->winner];
if (dp->cfdp)
*ds->cfdp = conn->cfd;
if (ds->dir) {
- strncpy(ds->dir, conn->dir, NETPATHLEN);
- ds->dir[NETPATHLEN] = '\0';
+ strncpy(ds->dir, conn->dir, NETPATHLEN-1);
+ ds->dir[NETPATHLEN-1] = '\0';
}
return conn->dfd;
}
to be clear, everyone seems to get confused with conn->dir vs ds->dir.
conn->dir has NETPATHLEN+1 capacity (why? makes no sense..). theres no
overflow at conn->dir. but ds->dir is a pointer to the connection dir
string passed by the caller of dial(). this buffer is just 40 (NETPATHLEN)
bytes long (thats its required minimum size), so doing:
ds->dir[NETPATHLEN] = '\0';
will write beyond it.
theres no patch yet. geoff is notified of the issue.
--
cinap
next prev parent reply other threads:[~2012-09-08 22:27 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 1:51 Jeff Sickel
2012-08-21 1:59 ` erik quanstrom
2012-08-21 4:23 ` arisawa
2012-08-21 5:08 ` Jeff Sickel
2012-08-21 8:42 ` Kenji Arisawa
2012-08-21 11:27 ` cinap_lenrek
2012-08-21 12:18 ` Lucio De Re
2012-08-21 12:37 ` arisawa
2012-08-21 18:32 ` erik quanstrom
2012-08-21 20:05 ` Charles Forsyth
[not found] ` <CAOw7k5hALBex13jJUbscVt4th-Z9urpmAP0eOBi7b1HuBQESrw@mail.gmail.c>
2012-08-21 20:41 ` erik quanstrom
2012-08-21 22:44 ` cinap_lenrek
2012-08-22 10:32 ` cinap_lenrek
2012-08-22 12:09 ` Kenji Arisawa
2012-08-22 12:35 ` cinap_lenrek
2012-08-22 13:05 ` erik quanstrom
2012-08-22 13:08 ` erik quanstrom
2012-08-22 13:11 ` Charles Forsyth
[not found] ` <CAOw7k5gGhL-=E=V1C9ffQP7qMyUVMhtrgpzLMidnCsHFGDzHwA@mail.gmail.c>
2012-08-22 13:18 ` erik quanstrom
2012-08-22 13:21 ` Charles Forsyth
2012-08-22 13:31 ` cinap_lenrek
2012-08-22 14:22 ` erik quanstrom
2012-08-22 14:41 ` Charles Forsyth
2012-08-22 14:47 ` cinap_lenrek
2012-08-22 15:26 ` erik quanstrom
2012-08-22 15:33 ` erik quanstrom
2012-08-22 15:35 ` erik quanstrom
[not found] ` <CAOw7k5jOE0Bf13fXJ04dUF4vGniRTJ1LwEMV1Oqw=AFKg77boA@mail.gmail.com>
2012-08-22 16:05 ` Charles Forsyth
2012-08-22 13:23 ` Lucio De Re
2012-08-25 0:10 ` Kenji Arisawa
2012-08-25 10:54 ` cinap_lenrek
2012-08-25 12:37 ` Kenji Arisawa
2012-08-25 13:22 ` cinap_lenrek
2012-08-25 13:38 ` cinap_lenrek
2012-08-25 13:41 ` Charles Forsyth
2012-08-25 13:44 ` cinap_lenrek
2012-08-27 22:44 ` arisawa
2012-08-28 1:45 ` cinap_lenrek
2012-08-28 1:57 ` erik quanstrom
2012-08-28 2:08 ` cinap_lenrek
2012-08-28 4:03 ` erik quanstrom
2012-09-08 17:37 ` Skip Tavakkolian
2012-09-08 18:02 ` cinap_lenrek
2012-09-08 18:18 ` cinap_lenrek
2012-09-08 21:53 ` Skip Tavakkolian
2012-09-08 22:27 ` cinap_lenrek [this message]
2012-09-09 2:09 ` Charles Forsyth
2012-09-09 2:37 ` cinap_lenrek
2012-09-09 3:01 ` Charles Forsyth
[not found] ` <CAOw7k5jydN7wssxBEqTc6h9FtLErjkoyxyfuQZLgcBTZ-nRgiw@mail.gmail.c>
2012-09-09 4:26 ` erik quanstrom
2012-09-09 5:28 ` Skip Tavakkolian
2012-08-25 21:56 ` cinap_lenrek
2012-08-26 13:16 ` cinap_lenrek
2012-08-26 13:36 ` Charles Forsyth
2012-08-21 5:08 ` Benjamin Huntsman
-- strict thread matches above, loose matches on Subject: below --
2017-04-01 1:28 [9fans] DNS cinap_lenrek
2017-04-01 3:40 ` Skip Tavakkolian
2017-04-01 9:46 ` Alexandru Gheorghe
2017-04-01 17:04 ` Steve Simon
2017-04-03 7:06 ` David Arroyo
2017-03-20 7:26 Skip Tavakkolian
2017-03-21 19:19 ` Skip Tavakkolian
2017-03-30 22:19 ` Steve Simon
2017-03-31 7:43 ` Peter Hull
2012-08-26 14:48 [9fans] dns cinap_lenrek
2007-08-15 19:26 erik quanstrom
2007-07-03 20:54 erik quanstrom
2007-07-04 20:51 ` geoff
2007-07-04 21:18 ` erik quanstrom
2007-07-04 21:52 ` geoff
2004-03-20 2:25 David Presotto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518935cf94deb137205a6f672a01c3ee@rei2.9hal \
--to=cinap_lenrek@gmx.de \
--cc=9fans@9fans.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).