From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <5323b750f50b30ff0911d940775e072d@quanstro.net>
To: 9fans@9fans.net
From: erik quanstrom <quanstro@quanstro.net>
Date: Tue,  1 Jul 2008 05:09:06 -0400
In-Reply-To: <20080701022925.GA19265@dinah>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Subject: Re: [9fans] 9vx
Topicbox-Message-UUID: d1cb15a8-ead3-11e9-9d60-3106f5b1d025

>> I added devsd and wrote an sd loopback yesterday afternoon.
>> It worked pretty well except that when I ran fdisk,
>> /dev/sd00/data disappeared.  I was going to debug that
>> before saying anything.
>
> Here's the fix for the fdisk problem:
>
> /sys/src/cmd/disk/prep/edit.c:503,508 - edit.c:503,509
>   	 */
>   	for(i=0; i<edit->nctlpart; i++) {
>   		p = edit->ctlpart[i];
> + 		if(strncmp(p->ctlname, "data", 5) != 0)
>   		if(p->changed)
>   		if(fprint(ctlfd, "delpart %s\n", p->ctlname)<0) {
>   			fprint(2, "delpart failed: %s: %r\n", p->ctlname);


i don't think this is the right solution.

as geoff pointed out, fdisk shouldn't be deleteing the parent
partition or any partitions that lie outside its parent partition.

obviously prep has a similar problem.

- erik