From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [9fans] bug in disk/format Content-Type: text/plain; charset=US-ASCII; format=flowed Mime-Version: 1.0 (Apple Message framework v481) From: Michael Baldwin To: 9fans@cse.psu.edu Content-Transfer-Encoding: 7bit In-Reply-To: Message-Id: <5606E0C4-713B-11D6-8643-000393726A14@orb.sh> Date: Mon, 27 May 2002 02:31:11 -0400 Topicbox-Message-UUID: 9cfafa4a-eaca-11e9-9e20-41e7f4b1d025 rsc writes: > For better or worse, the sd53c8xx driver > truncates very large writes (like an entire kernel!). It returns > the correct short write count, but format wasn't checking > for short writes. umm, isn't this a bug in the driver? the man page for write(2) says, The number of characters actually written is returned. It should be regarded as an error if this is not the same as requested. so yes, disk/format should check for short writes, but it should fail with a write error if it gets one, no? question, if it is an error, should errstr() be set?